Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Remove direct references to newrelic #621

Closed
11 tasks done
timmc-edx opened this issue May 2, 2024 · 5 comments
Closed
11 tasks done

[APM] Remove direct references to newrelic #621

timmc-edx opened this issue May 2, 2024 · 5 comments

Comments

@timmc-edx
Copy link
Member

timmc-edx commented May 2, 2024

We have some code in edx-platform (and possibly elsewhere) that directly imports and uses newrelic rather than going through edx-django-utils (e.g. in StaticContentServer). These all need to be switched over to edx-django-utils.

A/C:

  • Remaining newrelic references in codebase identified
  • References replaced with edx_django_utils calls or ticketed for dealing with later

Worklist:

@timmc-edx timmc-edx converted this from a draft issue May 2, 2024
@robrap robrap moved this to Prioritized in Arch-BOM May 2, 2024
@timmc-edx timmc-edx changed the title Remove direct references to newrelic [APM] Remove direct references to newrelic May 13, 2024
@robrap
Copy link
Contributor

robrap commented May 20, 2024

Maybe most of this should be about informing maintainers?

@robrap robrap removed the status in Arch-BOM May 20, 2024
@timmc-edx
Copy link
Member Author

Yeah. I've gone ahead and just notified each team; they can migrate on their own schedule. I think the only thing left is this set_monitoring_transaction_name issue and I'm inclined to suggest that the owning team of the relying code should plan to set a new span tag and use that instead in their new dashboards and alerts (and we can deprecate that from e-d-u.)

@robrap
Copy link
Contributor

robrap commented May 21, 2024

I think the only thing left is this set_monitoring_transaction_name issue ...

Could we just document that as not being available for certain backends, in addition to your intended communications?

@timmc-edx
Copy link
Member Author

It's already documented: https://github.com/openedx/edx-django-utils/tree/master/edx_django_utils/monitoring#choice-of-monitoring-tools

I haven't gone through and checked if other such newrelic-specific functions are used in the codebase, though.

@timmc-edx
Copy link
Member Author

Filed openedx/edx-django-utils#419 to cover the remaining NR-specific functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants