Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test edx-platform Django settings refactor PRs on a sandbox #903

Open
1 task
robrap opened this issue Jan 23, 2025 · 1 comment
Open
1 task

Test edx-platform Django settings refactor PRs on a sandbox #903

robrap opened this issue Jan 23, 2025 · 1 comment
Assignees

Comments

@robrap
Copy link
Contributor

robrap commented Jan 23, 2025

Context:

There are about to be a number of setting refactor PRs that need to be tested to ensure they won't break edx.org.

The initial PR, openedx/edx-platform#36115, did break edx.org and we are looking to prevent that from recurring. It would be useful to check that this test process would have found that breakage.

Acceptance Criteria:

Implementation Notes

  • First, do a diff of settings configured in edx-internal. edge-internal, and sandbox-internal, and create a branch in sandbox-internal that sets all settings touched by prod and edge.
  • The idea is simply to set up a sandbox and do a diff of dumps of the settings before and after a change.
  • @kdmccormick is working on a management command to dump the settings.
  • Consider extending the lifetime of the sandbox a little for re-use, or just rebuild as needed.
  • Consider storing the settings some place (maybe not publicly), so we don't have to do the before-dump each time.
  • See #openedx-cc-edx-platform Slack thread for more background, or from Open edX Slack, search for "Merged a settings refactoring" from Kyle.
@robrap robrap added this to Arch-BOM Jan 23, 2025
@robrap robrap moved this to Ready For Development in Arch-BOM Jan 24, 2025
@dianakhuang dianakhuang self-assigned this Jan 24, 2025
@kdmccormick
Copy link

PR to add the dump_settings management command: openedx/edx-platform#36162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready For Development
Development

No branches or pull requests

3 participants