Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bumped frontend-platform to v6 #124

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

BilalQamar95
Copy link
Contributor

Description:

  • Major version upgrades for frontend-platform & paragon
  • Updated failing tests

@BilalQamar95 BilalQamar95 self-assigned this Jan 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 174 lines in your changes are missing coverage. Please review.

Comparison is base (445b365) 91.59% compared to head (68e5115) 67.76%.
Report is 114 commits behind head on main.

Files Patch % Lines
...r-steps/view-results/RelatedSkillsSingleBoxSet.jsx 4.25% 45 Missing ⚠️
...lect-preferences/CareerInterestCategorizinator.jsx 2.77% 34 Missing and 1 partial ⚠️
...ps/view-results/RelatedSkillsInteractiveBoxSet.jsx 0.00% 23 Missing ⚠️
.../skills-builder-steps/SkillsBuilderProgressive.jsx 6.66% 14 Missing ⚠️
src/skills-builder/ProductTool.jsx 9.09% 10 Missing ⚠️
...lls-builder/visibility-flags-context/data/hooks.js 9.09% 8 Missing and 2 partials ⚠️
...s-builder/visibility-flags-context/data/reducer.js 0.00% 7 Missing and 1 partial ⚠️
...-steps/select-preferences/CareerInterestSelect.jsx 54.54% 4 Missing and 1 partial ⚠️
...builder-steps/view-results/RecommendationStack.jsx 72.22% 5 Missing ⚠️
.../skills-builder-steps/view-results/ViewResults.jsx 85.29% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #124       +/-   ##
===========================================
- Coverage   91.59%   67.76%   -23.84%     
===========================================
  Files          30       43       +13     
  Lines         369      639      +270     
  Branches       68      152       +84     
===========================================
+ Hits          338      433       +95     
- Misses         30      196      +166     
- Partials        1       10        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxFrank13
Copy link
Member

Thanks for fixing the tests up in the process @BilalQamar95. It looks like there are conflicts to resolve in package-lock.json. If you get a chance to resolve those, we can take another look and approve this PR 👍

@jsnwesson
Copy link
Member

I went ahead and resolved the package-lock.json conflicts, as it was just due to react-router and react-router-dom getting upgraded. Thanks for working on this, @BilalQamar95 !

@jsnwesson jsnwesson merged commit b9dfb88 into main Feb 15, 2024
4 checks passed
@jsnwesson jsnwesson deleted the bilalqamar95/frontend-platform-upgrade branch February 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants