Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add product tour experiment #29

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

alangsto
Copy link
Member

@alangsto alangsto commented Sep 20, 2023

MST-2143

Add product tour as part of optimizely experiment.

Screenshot 2023-09-20 at 2 49 49 PM

Product tour is displayed until a user has clicked "Check it out".

@alangsto alangsto force-pushed the alangsto/add_product_tour branch from fa5e6b4 to 3cd9414 Compare September 21, 2023 14:36
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #29 (d501bb9) into main (9f59a46) will decrease coverage by 0.80%.
Report is 1 commits behind head on main.
The diff coverage is 85.29%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   87.86%   87.06%   -0.80%     
==========================================
  Files          11       13       +2     
  Lines         173      201      +28     
  Branches       21       26       +5     
==========================================
+ Hits          152      175      +23     
- Misses         21       26       +5     
Files Changed Coverage Δ
src/components/ToggleXpertButton/index.jsx 85.29% <76.19%> (-14.71%) ⬇️
src/data/optimizely.js 100.00% <100.00%> (ø)
src/data/thunks.js 94.87% <100.00%> (+0.27%) ⬆️
src/utils/optimizelyExperiment.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alangsto alangsto force-pushed the alangsto/add_product_tour branch from 3cd9414 to d501bb9 Compare September 21, 2023 16:45
@alangsto alangsto marked this pull request as ready for review September 21, 2023 16:46
"core-js": "3.31.1",
"prop-types": "15.8.1",
"react-markdown": "^8.0.5"
"react-markdown": "^8.0.5",
"uuid": "9.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UUID has to be moved to dependencies due to optimizely/javascript-sdk#791

Copy link
Member

@MichaelRoytman MichaelRoytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@alangsto alangsto merged commit 26a44a0 into main Sep 21, 2023
3 of 5 checks passed
@alangsto alangsto deleted the alangsto/add_product_tour branch September 21, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants