diff --git a/lib/plugins/reviewRequestDelegation.js b/lib/plugins/reviewRequestDelegation.js index 2305945d..7263a4e1 100644 --- a/lib/plugins/reviewRequestDelegation.js +++ b/lib/plugins/reviewRequestDelegation.js @@ -125,10 +125,10 @@ module.exports = class ReviewRequestDelegation extends ErrorStash { } }) - const changes = this.mergeDeep.compareDeep(entry, comparableAttrs) + if (this.nop) { + const changes = this.mergeDeep.compareDeep(entry, comparableAttrs) - if (changes.hasChanges) { - if (this.nop) { + if (changes.hasChanges) { return Promise.resolve([ new NopCommand(this.constructor.name, { repo: slug, @@ -137,10 +137,10 @@ module.exports = class ReviewRequestDelegation extends ErrorStash { ]) } - return this.update(slug, entry, safeAttrs) + return Promise.resolve() } - return Promise.resolve() + return this.update(slug, entry, safeAttrs) } async update (slug, existing, attrs) {