Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix makefile and dv setup #42

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix makefile and dv setup #42

wants to merge 4 commits into from

Conversation

marwaneltoukhy
Copy link
Member

@marwaneltoukhy marwaneltoukhy commented Feb 23, 2023

+ dv includes file
~ fixed makefiles for dv setup
~ updated makefile to be the same as digital user project (without installation of openlane)
~ fixed includes in verilog and c files to have the same setup as digital user project

Copy link
Contributor

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A proper review would take more time than I have available; but it looks generally okay without doing a complete comparison to the setup of caravel_user_project. Recommend merging and testing.

@RTimothyEdwards
Copy link
Contributor

@jeffdi : I know you've been tied up in meetings today like I have, but we have designers waiting on this fix, so when you have the time, please review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants