New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magic tcl script should use proper argument parsing #186

Open

proppy opened this issue Feb 10, 2023 · 0 comments · May be fixed by #187

proppy commented Feb 10, 2023 •

edited

Loading

currently the magic script use fixed ascending index for command line parameters:
https://github.com/efabless/mpw_precheck/blob/main/checks/xor_check/erase_box.tcl#L2-L4
which seems fragile and can cause issue if wrapping the main magic executable in another shell script.

Are we considering relying on https://core.tcl-lang.org/tcllib/doc/tcllib-1-18/embedded/www/tcllib/files/modules/cmdline/cmdline.html or reversing the indexing order so that it's more resistant to changes adding new flag to the magic invocation.

proppy linked a pull request

that will close this issue

checks/magic: index arguments from end #187

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment