Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the 'EFCore.Design.Tests.Shared' project completely #24

Open
lorcQc opened this issue May 6, 2021 · 3 comments
Open
Assignees
Milestone

Comments

@lorcQc
Copy link
Collaborator

lorcQc commented May 6, 2021

No description provided.

@lorcQc lorcQc self-assigned this May 24, 2021
@lorcQc
Copy link
Collaborator Author

lorcQc commented May 24, 2021

Information

EFCore.Design.Tests.Shared is a C# project containing a test implementation of IRelationalTypeMappingSourcePlugin (TestTypeMappingPlugin.cs) and a class derived from RelationalTypeMappingSource (TestRelationalTypeMappingSource.cs).
They are used in unit tests.

I had put them there because the IRelationalTypeMappingSourcePlugin interface cannot be implemented in VB. It requires to implement a method containing an in parameter modifier. in is similar to the ByRef keyword, except that the in arguments cannot be changed by the called method. There is no equivalent in VB.
TestRelationalTypeMappingSource has not been translated because it also contains a method with an in keyword.

@lorcQc
Copy link
Collaborator Author

lorcQc commented May 24, 2021

TestTypeMappingPlugin.cs

Is only used in VisualBasicHelperTests.vb to test that method VisualBasicHelper.UnknownLiteral is capable of generating literals from expressions provided by a mapping source.

I believe it is possible to test this without having to implement IRelationalTypeMappingSourcePlugin.

We only need an IRelationalTypeMappingSource which implements this method
Public Function FindMapping(type As Type) As RelationalTypeMapping

@lorcQc
Copy link
Collaborator Author

lorcQc commented May 24, 2021

TestRelationalTypeMappingSource.cs

....

@bricelam bricelam added this to the Backlog milestone Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants