Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes benchmarks #26

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Pipes benchmarks #26

wants to merge 6 commits into from

Conversation

dhil
Copy link
Contributor

@dhil dhil commented May 10, 2022

This PR adds "flat pipes" and "nested pipes" from Kammar et al. (2013) "Handlers in Action".

@jO-Osko
Copy link
Collaborator

jO-Osko commented May 10, 2022

Looks good to me.
I would also propose a new label SHALLOW_HANDLERS (or something to that effect).

@jO-Osko jO-Osko mentioned this pull request May 10, 2022
@dhil
Copy link
Contributor Author

dhil commented May 10, 2022

I was thinking we should maybe modify the benchmarks slightly to return/produce some observable value. What do you think?

@dhil dhil requested a review from jO-Osko May 10, 2022 22:27
@jO-Osko
Copy link
Collaborator

jO-Osko commented May 11, 2022

That sounds good. Maybe just accumulate yielded values (or some operation over them to prevent compilers from optimizing too much).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants