-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: egg-bin debug pass debugOptions to startCluster #72
Conversation
@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2 and @dead-horse to be potential reviewers. |
@fengmk2 这个算不算 break change 呢 T_T |
对原来有影响? |
仅对本地开发调试有一点影响,原来 |
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 203 191 -12
=====================================
- Hits 203 191 -12
Continue to review full report at Codecov.
|
@fengmk2 结论是? |
不会只更新egg-bin而不更新egg-cluster的场景吧 |
是的,都是 ^ 的,虽然严格来说比起自己 break 了,但我们都是配套的,我倾向于不算 break。 |
还有没有其他问题,没的话合并? |
算 minor |
先合并 egg-cluster 然后发布,再发布 egg-bin |
4.3.0 |
Checklist
npm test
passesAffected core subsystem(s)
Description of change