Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: egg-bin debug pass debugOptions to startCluster #72

Merged
merged 3 commits into from
Sep 7, 2017
Merged

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Sep 5, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2 and @dead-horse to be potential reviewers.

@atian25
Copy link
Member Author

atian25 commented Sep 5, 2017

@fengmk2 这个算不算 break change 呢 T_T

@fengmk2
Copy link
Member

fengmk2 commented Sep 5, 2017

对原来有影响?

@atian25
Copy link
Member Author

atian25 commented Sep 5, 2017

仅对本地开发调试有一点影响,原来 egg-bin debug 的话,会启动调试模式了,现在改完后,就需要配合新的 egg-cluster 才能调试

@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines         203    191   -12     
=====================================
- Hits          203    191   -12
Impacted Files Coverage Δ
lib/cmd/debug.js 100% <100%> (ø) ⬆️
lib/command.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6592e5...7114747. Read the comment docs.

@atian25
Copy link
Member Author

atian25 commented Sep 6, 2017

@fengmk2 结论是?

@fengmk2
Copy link
Member

fengmk2 commented Sep 6, 2017

不会只更新egg-bin而不更新egg-cluster的场景吧

@atian25
Copy link
Member Author

atian25 commented Sep 6, 2017

是的,都是 ^ 的,虽然严格来说比起自己 break 了,但我们都是配套的,我倾向于不算 break。

@atian25
Copy link
Member Author

atian25 commented Sep 6, 2017

还有没有其他问题,没的话合并?

@fengmk2
Copy link
Member

fengmk2 commented Sep 6, 2017

算 minor

@fengmk2
Copy link
Member

fengmk2 commented Sep 6, 2017

先合并 egg-cluster 然后发布,再发布 egg-bin

@fengmk2 fengmk2 merged commit 83afba3 into master Sep 7, 2017
@fengmk2 fengmk2 deleted the debug branch September 7, 2017 01:32
@fengmk2
Copy link
Member

fengmk2 commented Sep 7, 2017

4.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants