-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revert debugOptions && support debug message #43
Conversation
PR #34 has implemented setting default port in config, so egg-cluster should not set the default port.
@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore, @dead-horse and @fengmk2 to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 97.83% 98.29% +0.45%
==========================================
Files 6 6
Lines 369 351 -18
==========================================
- Hits 361 345 -16
+ Misses 8 6 -2
Continue to review full report at Codecov.
|
到底应该先合并那个呢? |
先 egg-cluster |
1.11.2 |
Checklist
npm test
passesAffected core subsystem(s)
Description of change
eggjs/egg#1376 (comment)
egg-ready
消息附带 address 和 portdebug
消息移到 master 文件,以便在 brk 情况下也能发送