Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revert debugOptions && support debug message #43

Merged
merged 5 commits into from
Sep 13, 2017
Merged

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Sep 13, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

eggjs/egg#1376 (comment)

  • 回滚 egg-cluster 那个 PR 至 1.9.2
    • 去除 debug / debugAgent / debugBrk / debugAgentBrk 的支持
    • master 照样启动调试
    • agent 调试跟随 master,固定端口为 5856
  • pick feat: delete default port options that has defined in egg #40
  • egg-ready 消息附带 address 和 port
  • debug 消息移到 master 文件,以便在 brk 情况下也能发送
  • 分了几个 commit 的,第一个是 revert 的,按 commit 看可能会好看点。。。

@mention-bot
Copy link

@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore, @dead-horse and @fengmk2 to be potential reviewers.

@codecov
Copy link

codecov bot commented Sep 13, 2017

Codecov Report

Merging #43 into master will increase coverage by 0.45%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   97.83%   98.29%   +0.45%     
==========================================
  Files           6        6              
  Lines         369      351      -18     
==========================================
- Hits          361      345      -16     
+ Misses          8        6       -2
Impacted Files Coverage Δ
lib/app_worker.js 97.72% <ø> (-0.06%) ⬇️
lib/agent_worker.js 100% <ø> (ø) ⬆️
lib/master.js 98.14% <100%> (+0.96%) ⬆️
lib/utils/options.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 868f473...3d8abd9. Read the comment docs.

@fengmk2
Copy link
Member

fengmk2 commented Sep 13, 2017

到底应该先合并那个呢?

@atian25
Copy link
Member Author

atian25 commented Sep 13, 2017

先 egg-cluster

@fengmk2 fengmk2 merged commit 61b5b66 into master Sep 13, 2017
@fengmk2 fengmk2 deleted the revert branch September 13, 2017 10:02
@fengmk2
Copy link
Member

fengmk2 commented Sep 13, 2017

1.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants