Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for rendering nodes in graphviz that contain newlines (
\n
).Note that the default egglog parser is not able to create strings with newlines (i.e. the string
"\n"
ends up with the newline escaped during parsing), but the Python bindings are able to create them.Previously, newlines were emitted as-is in the graphviz output, as newlines in the file, which meant they were not rendered.
I tested this PR with this code:
Which now renders like this:
But previously was like this:
EDIT: I also added a
BALIGN="left"
so that the lines separated by<br />
are aligned left, instead of centered, and tested this.