Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch storage recall crashes/reboots module #97

Open
mrmattallison opened this issue Oct 18, 2024 · 11 comments
Open

Patch storage recall crashes/reboots module #97

mrmattallison opened this issue Oct 18, 2024 · 11 comments

Comments

@mrmattallison
Copy link

Hi @eh2k,

I'm experiencing an issue whereby if I recall saved patches the module reboots reverting back to the previous module settings, not the recalled patch. Any ideas on what could be causing this? It doesn't seem to follow a particular workflow in that sometimes the same patch will load fine, other times it will reboot the module and I'll need to try load another patch, then reload the previous patch.

@mrmattallison
Copy link
Author

IMG_6479.mov

Video attached of the stated behaviour

@mrmattallison
Copy link
Author

On further investigation it seems I can recall Patch 1, 2 & 8 without any issues, every time, but the rest are all a gamble.

@eh2k
Copy link
Owner

eh2k commented Oct 18, 2024

@mrmattallison, thanks for reporting.

Looks like the same issue: #88 (comment)

I'm thinking about adding the possibility to dump the patches as sysex in the next version. I could then analyze them - maybe there is an infinite loop which leads to a reset by the watchdog.

@mrmattallison
Copy link
Author

Ah! Thanks, yeah, seems to be a similar/same issue. I haven’t tried the TR style drums machines then/there, but the save and recall seems to be similar.

Let me know if there is anything I can test my end to further assist, otherwise I look forward to the next version with the suggested sysex changes.

@eh2k
Copy link
Owner

eh2k commented Oct 19, 2024

Unfortunately, I cannot reproduce this. I would actually need an exact step-by-step description of how the patch is created. It could also be that there is not enough RAM when loading.

If you press the right button at startup, no patch is loaded. So you could try to load the patch from the scratch. Alternatively, you could try to rebuild the patch, then save the patch and load it again, which might lead to a crash.

@eh2k
Copy link
Owner

eh2k commented Nov 14, 2024

Probably fixed in 3a6a2c8

@eh2k
Copy link
Owner

eh2k commented Nov 15, 2024

I just have a question is it normal that the module reboot when i load a Patch ? from patch storage ?

Originally posted by @rootapprox in #100 (comment)

No - it's not normal.
I have to test this again, I optimized something in the last version.

@rootapprox
Copy link

Thanks a lot for verifying that ! @eh2k

@eh2k
Copy link
Owner

eh2k commented Nov 24, 2024

@rootapprox

I think I have found the cause (was something different), or I will fix it with the next update.

Patches cannot be loaded at the current version if they exceed 256 bytes. The size of the patch is dynamic - depending on which engines and how many modulations are configured.

@eh2k eh2k mentioned this issue Nov 24, 2024
@eh2k eh2k closed this as completed Nov 24, 2024
@rootapprox
Copy link

@eh2k Makes complete sense , cause i do use lot of modulations and maybe some designed fxs shared from the other friend here in the group

@eh2k eh2k reopened this Nov 25, 2024
eh2k added a commit that referenced this issue Nov 30, 2024
eh2k added a commit that referenced this issue Nov 30, 2024
@eh2k
Copy link
Owner

eh2k commented Nov 30, 2024

@rootapprox - Hope the loading issue is fixed with 4b66d27.

eh2k added a commit that referenced this issue Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants