Replace python template with a yaml template deployed in cluster #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow system engineers to more easily make configurations to the suite runner Job without adding code to the repository. This template should become a CRD in the future when we are ready for ETOS to become an operator.
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
fredjn
reviewed
Apr 23, 2024
The filebeat template is hard to use since we tend to deploy ETOS using the etos repository. We also do not have filebeat configurations for any other service in ETOS. This should be up to the deployer of ETOS to set up for all services.
fredjn
approved these changes
Apr 23, 2024
andmat900
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
fixes: eiffel-community/etos#229
Description of the Change
This will allow system engineers to more easily make configurations to the suite runner Job without adding code to the repository.
Alternate Designs
I actually want to create the ESR template as a custom resource definition, but I don't think we are quite there yet with ETOS. We should wait until we are ready to convert ETOS to become a Kubernetes Operator.
Possible Drawbacks
With the current implementation a full replacement is required to patch the ESR template, which may cause deployments to drift away from the base template in this repository. This will be solved when we create the ESR template as a custom resource in Kubernetes.
Another thing is that I have not added support to add more configuration parameters to the suite starter. This is something that we want, but I did not want to add everything in this first iteration. A follow-up feature request will be written for this support.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]