Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CallContract starknet event parsing logic #19

Merged
merged 11 commits into from
Apr 30, 2024
Merged

feat: add CallContract starknet event parsing logic #19

merged 11 commits into from
Apr 30, 2024

Conversation

ctoyan
Copy link
Member

@ctoyan ctoyan commented Apr 25, 2024

Description

Implements 78 in the giza-axelar-starknet repository.

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Run the unit tests

@ctoyan ctoyan self-assigned this Apr 25, 2024
@ctoyan ctoyan force-pushed the feat/starknet-contract-call branch from 7305334 to 9cbd79d Compare April 25, 2024 15:40
puhtaytow
puhtaytow approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@puhtaytow puhtaytow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ampd/src/starknet/events/contract_call.rs Show resolved Hide resolved
ampd/src/starknet/events/mod.rs Show resolved Hide resolved
tomekpiotrowski
tomekpiotrowski suggested changes Apr 29, 2024
View reviewed changes
ampd/src/starknet/events/contract_call.rs Show resolved Hide resolved
ampd/src/starknet/events/mod.rs Show resolved Hide resolved
ampd/src/starknet/types/array_span.rs Outdated Show resolved Hide resolved
ampd/src/starknet/events/contract_call.rs Show resolved Hide resolved
ampd/src/starknet/events/contract_call.rs Outdated Show resolved Hide resolved
ampd/src/starknet/events/contract_call.rs Show resolved Hide resolved
@ctoyan ctoyan force-pushed the feat/starknet-contract-call branch from 36284c6 to 89262ca Compare April 29, 2024 16:23
@ctoyan
Copy link
Member Author

ctoyan commented Apr 29, 2024

Test pass and clippy passes locally.
I presume that the CI doesn't pass, because Axelar use a custom workflow runner and in our organisation the tasks just stay queued and are never picked up.

@ctoyan ctoyan force-pushed the feat/starknet-contract-call branch from 8234f97 to d125f09 Compare April 29, 2024 19:22
@ctoyan ctoyan merged commit 6031461 into starknet Apr 30, 2024
1 of 5 checks passed
@ctoyan ctoyan deleted the feat/starknet-contract-call branch April 30, 2024 13:56
ctoyan added a commit that referenced this pull request Jun 10, 2024
@ctoyan
feat: add CallContract starknet event parsing logic (#19)
cb45468
ctoyan added a commit that referenced this pull request Jun 10, 2024
@ctoyan
feat: add CallContract starknet event parsing logic (#19)
2821ebf
ctoyan added a commit that referenced this pull request Aug 7, 2024
@ctoyan
feat: add CallContract starknet event parsing logic (#19)
c1abf95
ctoyan added a commit that referenced this pull request Sep 9, 2024
@ctoyan
feat: add CallContract starknet event parsing logic (#19)
c1bc456
ctoyan added a commit that referenced this pull request Sep 9, 2024
@ctoyan
feat: add CallContract starknet event parsing logic (#19)
b7ba110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekpiotrowski tomekpiotrowski tomekpiotrowski requested changes

@puhtaytow puhtaytow puhtaytow approved these changes

Assignees

@ctoyan ctoyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctoyan @tomekpiotrowski @puhtaytow