-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add JamTime, TimeSlot and Epoch implementation #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranw
changed the title
WIP: feat: add JamTime, TimeSlot and Epoch implementation
feat: add JamTime, TimeSlot and Epoch implementation
Jul 29, 2024
pantrif
reviewed
Jul 30, 2024
pantrif
reviewed
Jul 30, 2024
bamzedev
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should generally return errors.
asmie
requested changes
Jul 30, 2024
danielvladco
previously approved these changes
Jul 31, 2024
danielvladco
previously approved these changes
Aug 2, 2024
danielvladco
previously approved these changes
Aug 2, 2024
pantrif
reviewed
Aug 5, 2024
bamzedev
previously approved these changes
Aug 7, 2024
asmie
previously approved these changes
Aug 7, 2024
pantrif
reviewed
Aug 8, 2024
pantrif
previously approved these changes
Aug 9, 2024
bamzedev
reviewed
Aug 9, 2024
it is extremely unlikely that we'll ever get an error from converting Now() to JamTime due to the date range of Jam. For this to error we'd expect a computers clock to extremely block and at that point we expect other things would just never work so for that reason this change was made
bamzedev
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First go at the JamTime stuff. Still got some testing to do for this package
I renamed the package from
time
tojamtime
so that it did not clash with the standard librarytime
package. Without remaining we'd of had to alias one of the packagesor