feat: parse PVM program blob #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielvladco
force-pushed
the
feat/parse-pvm-program
branch
from
4b57e7f to
aadb98b
Compare
danielvladco
force-pushed
the
feat/parse-pvm-program
branch
from
aadb98b to
24fc849
Compare
13 tasks
pantrif
reviewed
Aug 19, 2024
danielvladco
force-pushed
the
feat/parse-pvm-program
branch
from
a69a248 to
967f457
Compare
|
The overall comment - maybe we should introduce a division into Polka Host - so something that's reading the blob, preparing all the data and structures, and runs the second part - so the PVM itself. |
asmie
requested changes
Aug 21, 2024
danielvladco
force-pushed
the
feat/parse-pvm-program
branch
from
e6bd29b to
5ad5d0c
Compare
danielvladco
force-pushed
the
feat/parse-pvm-program
branch
from
5ad5d0c to
b04ff15
Compare
|
Most of this all looks okay to me from what I can tell. But something that does stand out is the number of panics? Do we want to instead return errors rather than panic in this code? I realise you've marked a few of these as unreachable but just wanted to raise it and discuss it |
asmie
approved these changes
Aug 23, 2024
|
@aranw , the panics are there for cases that should never happen, this is why I put panics as we expect those code parts to be "unreachable" and if we get there something went terribly wrong, in rust they use assert and unreachable macro for this I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the program binary.
This initial iteration adds the program parsing component, it takes in a bytes reader and decodes each section of the program into jump table, a set of instructions, import and export functions.
The logic is based on https://github.com/koute/polkavm