Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PurgeTimeout as a optional actor option #128

Open
eliasdarruda opened this issue Jan 20, 2023 · 3 comments
Open

PurgeTimeout as a optional actor option #128

eliasdarruda opened this issue Jan 20, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers operator protocol Specification of protocol proxy
Milestone

Comments

@eliasdarruda
Copy link
Collaborator

eliasdarruda commented Jan 20, 2023

We need to add a option that purges all data related with the actor, it will clean its state and delete the entry from the Statestore after a configured time.

It can be called PurgeTimeout, DestroyTimeout or something like that, open to suggestions on the naming pattern.

Should it de-register from all hosts too? @sleipnir WDYT?

@eliasdarruda eliasdarruda added enhancement New feature or request good first issue Good for newcomers labels Jan 20, 2023
@eliasdarruda eliasdarruda added this to the v1.0.0 milestone Jan 20, 2023
@sleipnir sleipnir moved this to Todo in Spawn v1.0.0 Jan 20, 2023
@sleipnir
Copy link
Member

sleipnir commented Jan 20, 2023

We need to add a option that purges all data related with the actor, it will clean its state and delete the entry from the Statestore after a configured time.

It can be called PurgeTimeout, DestroyTimeout or something like that, open to suggestions on the naming pattern.

Should it de-register from all hosts too? @sleipnir WDYT?

This is an old wish of mine.
I think we have to keep a few things in mind when implementing this:

  1. We must stipulate a minimum default period for an actor without updating for more than N days to remain in the Statesstore. I would suggest 90 days.
  2. User can allow data to never be deleted (maybe this is the best option for Default timeout).
  3. We must consider the update date of the state, that is, the updated_at column
  4. I suggest that the configuration has a name that addresses the question of the Actor's non-usefulness. Something like
    purgeUnusedActors or something like that.
  5. The process responsible for validating and cleaning this up must also be global. Similar to what we do with the Schedule invocation

@sleipnir
Copy link
Member

sleipnir commented Jan 20, 2023

ping @marcellanz

@sleipnir
Copy link
Member

@eliasdarruda we can add an option called ttl to the ActorSettings

@sleipnir sleipnir removed this from Spawn v1.5.0 Sep 19, 2024
@sleipnir sleipnir moved this to Backlog in Spawn v1.6.0 Sep 19, 2024
@sleipnir sleipnir modified the milestones: v1.0.0, 1.6.0 Sep 19, 2024
@sleipnir sleipnir added protocol Specification of protocol proxy operator labels Sep 20, 2024
@sleipnir sleipnir self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers operator protocol Specification of protocol proxy
Projects
Status: Backlog
Development

No branches or pull requests

2 participants