fieldmask: consider field behavior for applying updates #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nlachfr Given the merged Pull Request and @DavyJ0nes comment can we close this? |
|
This PR has been open for 180 days with no activity. Remove the stale label or add a comment or it will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite fieldmask.Update function by adding logic for handling field behavior.
aip-go/fieldmask/update.go
Line 22 in b48c9c9
I kept the same logic, with specific handling for
OUTPUT_ONLYandIMMUTABLEbehaviors :OUTPUT_ONLYfields are excluded from the updateIMMUTABLEfields raise an error when the value in dst and src differsI will try to add new tests regarding these cases.
Fixes #134