diff --git a/.github/dependabot.yml b/.github/dependabot.yml
new file mode 100644
index 000000000000..1e956d2faa00
--- /dev/null
+++ b/.github/dependabot.yml
@@ -0,0 +1,16 @@
+version: 2
+updates:
+# TODO(b/170636568): Enable Maven updates? Perhaps wait until we can more
+# easily import the generated PRs into our internal repo.
+# - package-ecosystem: "maven"
+# directory: "/"
+# schedule:
+# interval: "daily"
+# - package-ecosystem: "maven"
+# directory: "/android"
+# schedule:
+# interval: "daily"
+ - package-ecosystem: "github-actions"
+ directory: "/"
+ schedule:
+ interval: "daily"
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f3e07268881d..e0907fc21b4e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -13,28 +13,34 @@ jobs:
name: "${{ matrix.root-pom }} on JDK ${{ matrix.java }}"
strategy:
matrix:
- java: [ 8, 11 ]
+ java: [ 11, 17 ]
root-pom: [ 'pom.xml', 'android/pom.xml' ]
runs-on: ubuntu-latest
env:
ROOT_POM: ${{ matrix.root-pom }}
steps:
+ # Cancel any previous runs for the same branch that are still running.
+ - name: 'Cancel previous runs'
+ uses: styfle/cancel-workflow-action@0.9.1
+ with:
+ access_token: ${{ github.token }}
- name: 'Check out repository'
- uses: actions/checkout@v2
+ uses: actions/checkout@v2.4.0
- name: 'Cache local Maven repository'
- uses: actions/cache@v2.1.4
+ uses: actions/cache@v2.1.7
with:
path: ~/.m2/repository
key: maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
maven-
- name: 'Set up JDK ${{ matrix.java }}'
- uses: actions/setup-java@v1
+ uses: actions/setup-java@v2
with:
java-version: ${{ matrix.java }}
+ distribution: 'zulu'
- name: 'Install'
shell: bash
- run: mvn -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn install -U -DskipTests=true -f $ROOT_POM
+ run: mvn -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn install -U -Dmaven.test.skip -Dmaven.javadoc.skip -f $ROOT_POM
- name: 'Test'
shell: bash
run: MAVEN_OPTS=-Xmx6g mvn -B -P!standard-with-extra-repos verify -U -Dmaven.javadoc.skip=true -f $ROOT_POM
@@ -51,18 +57,19 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: 'Check out repository'
- uses: actions/checkout@v2
+ uses: actions/checkout@v2.4.0
- name: 'Cache local Maven repository'
- uses: actions/cache@v2.1.4
+ uses: actions/cache@v2.1.7
with:
path: ~/.m2/repository
key: maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
maven-
- name: 'Set up JDK 11'
- uses: actions/setup-java@v1
+ uses: actions/setup-java@v2
with:
java-version: 11
+ distribution: 'zulu'
server-id: sonatype-nexus-snapshots
server-username: CI_DEPLOY_USERNAME
server-password: CI_DEPLOY_PASSWORD
@@ -79,18 +86,19 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: 'Check out repository'
- uses: actions/checkout@v2
+ uses: actions/checkout@v2.4.0
- name: 'Cache local Maven repository'
- uses: actions/cache@v2.1.4
+ uses: actions/cache@v2.1.7
with:
path: ~/.m2/repository
key: maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
maven-
- name: 'Set up JDK 11'
- uses: actions/setup-java@v1
+ uses: actions/setup-java@v2
with:
java-version: 11
+ distribution: 'zulu'
- name: 'Generate latest docs'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/README-typetools.md b/README-typetools.md
index 5c191148d14c..62dec84f125b 100644
--- a/README-typetools.md
+++ b/README-typetools.md
@@ -13,10 +13,34 @@ To create file `guava/target/guava-HEAD-jre-SNAPSHOT.jar`:
(cd guava && mvn -B package -Dmaven.test.skip=true -Danimal.sniffer.skip=true)
```
-To use a locally-built Checker Framework, add `-P checkerframework-local`,
+To use a locally-built Checker Framework:
+```
+(cd guava && mvn -B package -Dmaven.test.skip=true -Danimal.sniffer.skip=true -P checkerframework-local)
+```
or change `guava/pom.xml`.
+To run the Guava test suite
+---------------------------
+
+This not strictly necessary as the CI process will run them. But if you wish to do so,
+it is a two step process. This can take a long time: 20-30 minutes for the compile step
+and 30-35 minutes for the test step. In order to shorten it a bit, the command lines
+below only run a single format checker. First, you must run maven with the install
+target to get a copy of all the generated jar files in your local maven repository:
+
+mvn -V -B -U clean install -Dcheckerframework.checkers=org.checkerframework.checker.formatter.FormatterChecker \
+ -Dcheck.value.phase=skip -Dmaven.test.skip -Dmaven.javadoc.skip
+
+Then you run the test suite:
+
+MAVEN_OPTS=-Xmx6g mvn -V -B -U verify -Dcheckerframework.checkers=org.checkerframework.checker.formatter.FormatterChecker \
+ -Dcheck.value.phase=skip -Dmaven.javadoc.skip
+
+Running with the single FormatterChecker gets the total time down to about 20-25 minutes,
+almost all testing. (Over 850,000 tests are run.)
+
+
Typechecking
------------
@@ -68,6 +92,10 @@ Whenever a Checker Framework release is made:
To update to a newer version of the upstream library
----------------------------------------------------
+First, update to use the latest Checker Framework by editing file
+`pom.xml` (for `checker-qual`) and `guava/pom.xml` (for `checker`).
+Make a pull request to ensure that type-checking succeeds.
+
Check for a release at
https://github.com/google/guava/releases
. If there has been one since the last time this repository was pulled,
@@ -80,8 +108,9 @@ git pull https://github.com/google/guava
```
and then re-build to ensure that typechecking still works.
-Doing this `git pull` permits incremental resolution of merge conflicts,
-but makes it difficult to re-release a given version of Guava.
+Note: Doing this `git pull` command
+makes it difficult to re-release a given version of Guava,
+compared to pulling in the tag corresponding to a release.
If you wish to see a simplified diff between this fork of Guava and upstream (to make sure that you did not make any mistakes when resolving merge conflicts):
@@ -143,7 +172,7 @@ yet written.
2. Pull in the latest Guava version (https://github.com/google/guava/releases):
```
git fetch --tags https://github.com/google/guava
-git pull https://github.com/google/guava v30.1.1
+git pull https://github.com/google/guava v31.1
```
3. Ensure that the project still builds:
diff --git a/README.md b/README.md
index 67b5a937d05a..8afda8fbb9e0 100644
--- a/README.md
+++ b/README.md
@@ -9,11 +9,11 @@ utilities for concurrency, I/O, hashing, caching, primitives, strings, and more!
is widely used on most Java projects within Google, and widely used by many
other companies as well.
-Guava comes in two flavors.
+Guava comes in two flavors:
* The JRE flavor requires JDK 1.8 or higher.
-* If you need support for JDK 1.7 or Android, use the Android flavor. You can
- find the Android Guava source in the [`android` directory].
+* If you need support for Android, use the Android flavor. You can find the
+ Android Guava source in the [`android` directory].
[`android` directory]: https://github.com/google/guava/tree/master/android
@@ -21,9 +21,9 @@ Guava comes in two flavors.
Guava's Maven group ID is `com.google.guava`, and its artifact ID is `guava`.
Guava provides two different "flavors": one for use on a (Java 8+) JRE and one
-for use on Android or Java 7 or by any library that wants to be compatible with
-either of those. These flavors are specified in the Maven version field as
-either `30.1-jre` or `30.1-android`. For more about depending on Guava, see
+for use on Android or by any library that wants to be compatible with Android.
+These flavors are specified in the Maven version field as either `31.1-jre` or
+`31.1-android`. For more about depending on Guava, see
[using Guava in your build].
To add a dependency on Guava using Maven, use the following:
@@ -32,9 +32,9 @@ To add a dependency on Guava using Maven, use the following:
com.google.guava
guava
- 30.1-jre
+ 31.1-jre
- 30.1-android
+ 31.1-android
```
@@ -45,16 +45,16 @@ dependencies {
// Pick one:
// 1. Use Guava in your implementation only:
- implementation("com.google.guava:guava:30.1-jre")
+ implementation("com.google.guava:guava:31.1-jre")
// 2. Use Guava types in your public API:
- api("com.google.guava:guava:30.1-jre")
+ api("com.google.guava:guava:31.1-jre")
// 3. Android - Use Guava in your implementation only:
- implementation("com.google.guava:guava:30.1-android")
+ implementation("com.google.guava:guava:31.1-android")
// 4. Android - Use Guava types in your public API:
- api("com.google.guava:guava:30.1-android")
+ api("com.google.guava:guava:31.1-android")
}
```
@@ -101,8 +101,10 @@ flavor.
plans to start removing things again, but officially, we're leaving our
options open in case of surprises (like, say, a serious security problem).
-3. Guava has one dependency that is needed at runtime:
- `com.google.guava:failureaccess:1.0.1`
+3. Guava has one dependency that is needed for linkage at runtime:
+ `com.google.guava:failureaccess:1.0.1`. It also has
+ [some annotation-only dependencies][guava-deps], which we discuss in more
+ detail at that link.
4. Serialized forms of ALL objects are subject to change unless noted
otherwise. Do not persist these and assume they can be read by a future
@@ -111,10 +113,10 @@ flavor.
5. Our classes are not designed to protect against a malicious caller. You
should not use them for communication between trusted and untrusted code.
-6. For the mainline flavor, we unit-test the libraries using only OpenJDK 1.8
- on Linux. Some features, especially in `com.google.common.io`, may not work
- correctly in other environments. For the Android flavor, our unit tests run
- on API level 15 (Ice Cream Sandwich).
+6. For the mainline flavor, we test the libraries using only OpenJDK 8 and
+ OpenJDK 11 on Linux. Some features, especially in `com.google.common.io`,
+ may not work correctly in other environments. For the Android flavor, our
+ unit tests also run on API level 15 (Ice Cream Sandwich).
[guava-snapshot-api-docs]: https://guava.dev/releases/snapshot-jre/api/docs/
[guava-snapshot-api-diffs]: https://guava.dev/releases/snapshot-jre/api/diffs/
@@ -125,3 +127,4 @@ flavor.
[using Guava in your build]: https://github.com/google/guava/wiki/UseGuavaInYourBuild
[repackage]: https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-if-i-want-to-use-beta-apis-from-a-library-that-people-use-as-a-dependency
+[guava-deps]: https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies
diff --git a/android/guava-bom/pom.xml b/android/guava-bom/pom.xml
index 8fde93d1a75a..736c02fd8044 100644
--- a/android/guava-bom/pom.xml
+++ b/android/guava-bom/pom.xml
@@ -8,7 +8,7 @@
com.google.guava
guava-bom
- HEAD-android-SNAPSHOT
+ 31.1-android
pom
diff --git a/android/guava-testlib/pom.xml b/android/guava-testlib/pom.xml
index 79b05190ce85..1fcf058676ee 100644
--- a/android/guava-testlib/pom.xml
+++ b/android/guava-testlib/pom.xml
@@ -5,7 +5,7 @@
com.google.guava
guava-parent
- HEAD-android-SNAPSHOT
+ 31.1-android
guava-testlib
Guava Testing Library
@@ -18,10 +18,6 @@
com.google.code.findbugs
jsr305
-
- org.checkerframework
- checker-compat-qual
-
com.google.errorprone
error_prone_annotations
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/AbstractContainerTester.java b/android/guava-testlib/src/com/google/common/collect/testing/AbstractContainerTester.java
index a5674d3db4d0..b86ef1750dee 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/AbstractContainerTester.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/AbstractContainerTester.java
@@ -188,7 +188,7 @@ protected ArrayWithDuplicate createArrayWithDuplicateElement() {
E[] elements = createSamplesArray();
E duplicate = elements[(elements.length / 2) - 1];
elements[(elements.length / 2) + 1] = duplicate;
- return new ArrayWithDuplicate(elements, duplicate);
+ return new ArrayWithDuplicate<>(elements, duplicate);
}
// Helper methods to improve readability of derived classes
@@ -211,7 +211,7 @@ protected Collection getSampleElements() {
* requirement {@link com.google.common.collect.testing.features.CollectionFeature#KNOWN_ORDER}.
*/
protected List getOrderedElements() {
- List list = new ArrayList();
+ List list = new ArrayList<>();
for (E e : getSubjectGenerator().order(new ArrayList(getSampleElements()))) {
list.add(e);
}
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/AbstractMapTester.java b/android/guava-testlib/src/com/google/common/collect/testing/AbstractMapTester.java
index 090442edc4da..5e0de3ccc443 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/AbstractMapTester.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/AbstractMapTester.java
@@ -72,8 +72,8 @@ protected void expectMissingValues(V... elements) {
/** @return an array of the proper size with {@code null} as the key of the middle element. */
protected Entry[] createArrayWithNullKey() {
Entry[] array = createSamplesArray();
- final int nullKeyLocation = getNullLocation();
- final Entry oldEntry = array[nullKeyLocation];
+ int nullKeyLocation = getNullLocation();
+ Entry oldEntry = array[nullKeyLocation];
array[nullKeyLocation] = entry(null, oldEntry.getValue());
return array;
}
@@ -97,8 +97,8 @@ private Entry getEntryNullReplaces() {
/** @return an array of the proper size with {@code null} as the value of the middle element. */
protected Entry[] createArrayWithNullValue() {
Entry[] array = createSamplesArray();
- final int nullValueLocation = getNullLocation();
- final Entry oldEntry = array[nullValueLocation];
+ int nullValueLocation = getNullLocation();
+ Entry oldEntry = array[nullValueLocation];
array[nullValueLocation] = entry(oldEntry.getKey(), null);
return array;
}
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java
index cf1ed23aa41e..5f9aff4f1c5f 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java
@@ -57,6 +57,8 @@ protected List createDerivedSuites(
.named(getName() + " reserialized")
.withFeatures(computeReserializedCollectionFeatures(parentBuilder.getFeatures()))
.suppressing(parentBuilder.getSuppressedTests())
+ .withSetUp(parentBuilder.getSetUp())
+ .withTearDown(parentBuilder.getTearDown())
.createTestSuite());
}
return derivedSuites;
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/DerivedCollectionGenerators.java b/android/guava-testlib/src/com/google/common/collect/testing/DerivedCollectionGenerators.java
index 3588e856fa23..a04d3ffe300a 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/DerivedCollectionGenerators.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/DerivedCollectionGenerators.java
@@ -96,9 +96,9 @@ public static class MapKeySetGenerator implements TestSetGenerator, Der
public MapKeySetGenerator(OneSizeTestContainerGenerator, Entry> mapGenerator) {
this.mapGenerator = mapGenerator;
- final SampleElements> mapSamples = this.mapGenerator.samples();
+ SampleElements> mapSamples = this.mapGenerator.samples();
this.samples =
- new SampleElements(
+ new SampleElements<>(
mapSamples.e0().getKey(),
mapSamples.e1().getKey(),
mapSamples.e2().getKey(),
@@ -203,9 +203,9 @@ public static class MapValueCollectionGenerator
public MapValueCollectionGenerator(
OneSizeTestContainerGenerator, Entry> mapGenerator) {
this.mapGenerator = mapGenerator;
- final SampleElements> mapSamples = this.mapGenerator.samples();
+ SampleElements> mapSamples = this.mapGenerator.samples();
this.samples =
- new SampleElements(
+ new SampleElements<>(
mapSamples.e0().getValue(),
mapSamples.e1().getValue(),
mapSamples.e2().getValue(),
@@ -239,14 +239,13 @@ public Collection create(Object... elements) {
@Override
public V[] createArray(int length) {
// noinspection UnnecessaryLocalVariable
- final V[] vs =
- ((TestMapGenerator) mapGenerator.getInnerGenerator()).createValueArray(length);
+ V[] vs = ((TestMapGenerator) mapGenerator.getInnerGenerator()).createValueArray(length);
return vs;
}
@Override
public Iterable order(List insertionOrder) {
- final List> orderedEntries =
+ List> orderedEntries =
castOrCopyToList(mapGenerator.order(castOrCopyToList(mapGenerator.getSampleElements(5))));
sort(
insertionOrder,
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/FeatureSpecificTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/FeatureSpecificTestSuiteBuilder.java
index 0d921a580896..db086aa3075e 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/FeatureSpecificTestSuiteBuilder.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/FeatureSpecificTestSuiteBuilder.java
@@ -81,7 +81,7 @@ public B withSetUp(Runnable setUp) {
return self();
}
- protected Runnable getSetUp() {
+ public Runnable getSetUp() {
return setUp;
}
@@ -90,13 +90,13 @@ public B withTearDown(Runnable tearDown) {
return self();
}
- protected Runnable getTearDown() {
+ public Runnable getTearDown() {
return tearDown;
}
// Features
- private Set> features = new LinkedHashSet<>();
+ private final Set> features = new LinkedHashSet<>();
/**
* Configures this builder to produce tests appropriate for the given features. This method may be
@@ -138,7 +138,7 @@ public String getName() {
// Test suppression
- private Set suppressedTests = new HashSet<>();
+ private final Set suppressedTests = new HashSet<>();
/**
* Prevents the given methods from being run as part of the test suite.
@@ -185,7 +185,7 @@ public TestSuite createTestSuite() {
TestSuite suite = new TestSuite(name);
for (Class testerClass : testers) {
- final TestSuite testerSuite =
+ TestSuite testerSuite =
makeSuiteForTesterClass((Class>) testerClass);
if (testerSuite.countTestCases() > 0) {
suite.addTest(testerSuite);
@@ -211,7 +211,7 @@ protected void checkCanCreate() {
protected abstract List> getTesters();
private boolean matches(Test test) {
- final Method method;
+ Method method;
try {
method = extractMethod(test);
} catch (IllegalArgumentException e) {
@@ -222,7 +222,7 @@ private boolean matches(Test test) {
logger.finer(Platform.format("%s: excluding because it was explicitly suppressed.", test));
return false;
}
- final TesterRequirements requirements;
+ TesterRequirements requirements;
try {
requirements = FeatureUtil.getTesterRequirements(method);
} catch (ConflictingRequirementsException e) {
@@ -268,8 +268,8 @@ private static Method extractMethod(Test test) {
}
protected TestSuite makeSuiteForTesterClass(Class> testerClass) {
- final TestSuite candidateTests = new TestSuite(testerClass);
- final TestSuite suite = filterSuite(candidateTests);
+ TestSuite candidateTests = new TestSuite(testerClass);
+ TestSuite suite = filterSuite(candidateTests);
Enumeration allTests = suite.tests();
while (allTests.hasMoreElements()) {
@@ -286,7 +286,7 @@ protected TestSuite makeSuiteForTesterClass(Class> t
private TestSuite filterSuite(TestSuite suite) {
TestSuite filtered = new TestSuite(suite.getName());
- final Enumeration tests = suite.tests();
+ Enumeration tests = suite.tests();
while (tests.hasMoreElements()) {
Test test = (Test) tests.nextElement();
if (matches(test)) {
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/Helpers.java b/android/guava-testlib/src/com/google/common/collect/testing/Helpers.java
index 8efafc373525..aac71cc4efe3 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/Helpers.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/Helpers.java
@@ -49,7 +49,7 @@ static boolean equal(Object a, Object b) {
// Clone of Lists.newArrayList
public static List copyToList(Iterable elements) {
- List list = new ArrayList();
+ List list = new ArrayList<>();
addAll(list, elements);
return list;
}
@@ -60,7 +60,7 @@ public static List copyToList(E[] elements) {
// Clone of Sets.newLinkedHashSet
public static Set copyToSet(Iterable elements) {
- Set set = new LinkedHashSet();
+ Set set = new LinkedHashSet<>();
addAll(set, elements);
return set;
}
@@ -188,11 +188,11 @@ public static boolean addAll(Collection addTo, Iterable elem
return modified;
}
- static Iterable reverse(final List list) {
+ static Iterable reverse(List list) {
return new Iterable() {
@Override
public Iterator iterator() {
- final ListIterator listIter = list.listIterator(list.size());
+ ListIterator listIter = list.listIterator(list.size());
return new Iterator() {
@Override
public boolean hasNext() {
@@ -213,7 +213,7 @@ public void remove() {
};
}
- static Iterator cycle(final Iterable iterable) {
+ static Iterator cycle(Iterable iterable) {
return new Iterator() {
Iterator iterator = Collections.emptySet().iterator();
@@ -251,7 +251,7 @@ static void fail(Throwable cause, Object message) {
}
public static Comparator> entryComparator(
- final Comparator keyComparator) {
+ Comparator keyComparator) {
return new Comparator>() {
@Override
@SuppressWarnings("unchecked") // no less safe than putting it in the map!
@@ -345,7 +345,7 @@ public static > void testCompareToAndEquals(
* @param delta the difference between the true size of the collection and the values returned by
* the size method
*/
- public static Collection misleadingSizeCollection(final int delta) {
+ public static Collection misleadingSizeCollection(int delta) {
// It would be nice to be able to return a real concurrent
// collection like ConcurrentLinkedQueue, so that e.g. concurrent
// iteration would work, but that would not be GWT-compatible.
@@ -363,7 +363,7 @@ public int size() {
* equals. This is used for testing unmodifiable collections of map entries; for example, it
* should not be possible to access the raw (modifiable) map entry via a nefarious equals method.
*/
- public static Entry nefariousMapEntry(final K key, final V value) {
+ public static Entry nefariousMapEntry(K key, V value) {
return new Entry() {
@Override
public K getKey() {
@@ -410,7 +410,7 @@ static List castOrCopyToList(Iterable iterable) {
if (iterable instanceof List) {
return (List) iterable;
}
- List list = new ArrayList();
+ List list = new ArrayList<>();
for (E e : iterable) {
list.add(e);
}
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java
index e01056459338..061e31038bda 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java
@@ -112,6 +112,8 @@ protected List createDerivedSuites(
.named(getName() + " reserialized")
.withFeatures(computeReserializedCollectionFeatures(parentBuilder.getFeatures()))
.suppressing(parentBuilder.getSuppressedTests())
+ .withSetUp(parentBuilder.getSetUp())
+ .withTearDown(parentBuilder.getTearDown())
.createTestSuite());
}
return derivedSuites;
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/MapInterfaceTest.java b/android/guava-testlib/src/com/google/common/collect/testing/MapInterfaceTest.java
index b8b5c28fb936..48491387851f 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/MapInterfaceTest.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/MapInterfaceTest.java
@@ -149,7 +149,7 @@ protected final boolean supportsValuesHashCode(Map map) {
for (V value : values) {
if (value != null) {
try {
- value.hashCode();
+ int unused = value.hashCode();
} catch (Exception e) {
return false;
}
@@ -265,7 +265,7 @@ private void assertEntrySetNotContainsString(Set> entrySet) {
protected void assertMoreInvariants(Map map) {}
public void testClear() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -286,8 +286,8 @@ public void testClear() {
}
public void testContainsKey() {
- final Map map;
- final K unmappedKey;
+ Map map;
+ K unmappedKey;
try {
map = makePopulatedMap();
unmappedKey = getKeyNotInPopulatedMap();
@@ -312,8 +312,8 @@ public void testContainsKey() {
}
public void testContainsValue() {
- final Map map;
- final V unmappedValue;
+ Map map;
+ V unmappedValue;
try {
map = makePopulatedMap();
unmappedValue = getValueNotInPopulatedMap();
@@ -334,8 +334,8 @@ public void testContainsValue() {
}
public void testEntrySet() {
- final Map map;
- final Set> entrySet;
+ Map map;
+ Set> entrySet;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -344,8 +344,8 @@ public void testEntrySet() {
assertInvariants(map);
entrySet = map.entrySet();
- final K unmappedKey;
- final V unmappedValue;
+ K unmappedKey;
+ V unmappedValue;
try {
unmappedKey = getKeyNotInPopulatedMap();
unmappedValue = getValueNotInPopulatedMap();
@@ -359,7 +359,7 @@ public void testEntrySet() {
}
public void testEntrySetForEmptyMap() {
- final Map map;
+ Map map;
try {
map = makeEmptyMap();
} catch (UnsupportedOperationException e) {
@@ -369,8 +369,8 @@ public void testEntrySetForEmptyMap() {
}
public void testEntrySetContainsEntryIncompatibleKey() {
- final Map map;
- final Set> entrySet;
+ Map map;
+ Set> entrySet;
try {
map = makeEitherMap();
} catch (UnsupportedOperationException e) {
@@ -379,7 +379,7 @@ public void testEntrySetContainsEntryIncompatibleKey() {
assertInvariants(map);
entrySet = map.entrySet();
- final V unmappedValue;
+ V unmappedValue;
try {
unmappedValue = getValueNotInPopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -396,8 +396,8 @@ public void testEntrySetContainsEntryNullKeyPresent() {
if (!allowsNullKeys || !supportsPut) {
return;
}
- final Map map;
- final Set> entrySet;
+ Map map;
+ Set> entrySet;
try {
map = makeEitherMap();
} catch (UnsupportedOperationException e) {
@@ -406,7 +406,7 @@ public void testEntrySetContainsEntryNullKeyPresent() {
assertInvariants(map);
entrySet = map.entrySet();
- final V unmappedValue;
+ V unmappedValue;
try {
unmappedValue = getValueNotInPopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -420,8 +420,8 @@ public void testEntrySetContainsEntryNullKeyPresent() {
}
public void testEntrySetContainsEntryNullKeyMissing() {
- final Map map;
- final Set> entrySet;
+ Map map;
+ Set> entrySet;
try {
map = makeEitherMap();
} catch (UnsupportedOperationException e) {
@@ -430,7 +430,7 @@ public void testEntrySetContainsEntryNullKeyMissing() {
assertInvariants(map);
entrySet = map.entrySet();
- final V unmappedValue;
+ V unmappedValue;
try {
unmappedValue = getValueNotInPopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -450,7 +450,7 @@ public void testEntrySetContainsEntryNullKeyMissing() {
}
public void testEntrySetIteratorRemove() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -488,7 +488,7 @@ public void testEntrySetIteratorRemove() {
}
public void testEntrySetRemove() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -512,8 +512,8 @@ public void testEntrySetRemove() {
}
public void testEntrySetRemoveMissingKey() {
- final Map map;
- final K key;
+ Map map;
+ K key;
try {
map = makeEitherMap();
key = getKeyNotInPopulatedMap();
@@ -540,7 +540,7 @@ public void testEntrySetRemoveMissingKey() {
}
public void testEntrySetRemoveDifferentValue() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -570,8 +570,8 @@ public void testEntrySetRemoveNullKeyPresent() {
if (!allowsNullKeys || !supportsPut || !supportsRemove) {
return;
}
- final Map map;
- final Set> entrySet;
+ Map map;
+ Set> entrySet;
try {
map = makeEitherMap();
} catch (UnsupportedOperationException e) {
@@ -580,7 +580,7 @@ public void testEntrySetRemoveNullKeyPresent() {
assertInvariants(map);
entrySet = map.entrySet();
- final V unmappedValue;
+ V unmappedValue;
try {
unmappedValue = getValueNotInPopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -597,7 +597,7 @@ public void testEntrySetRemoveNullKeyPresent() {
}
public void testEntrySetRemoveNullKeyMissing() {
- final Map map;
+ Map map;
try {
map = makeEitherMap();
} catch (UnsupportedOperationException e) {
@@ -626,7 +626,7 @@ public void testEntrySetRemoveNullKeyMissing() {
}
public void testEntrySetRemoveAll() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -663,7 +663,7 @@ public void testEntrySetRemoveAll() {
}
public void testEntrySetRemoveAllNullFromEmpty() {
- final Map map;
+ Map map;
try {
map = makeEmptyMap();
} catch (UnsupportedOperationException e) {
@@ -689,7 +689,7 @@ public void testEntrySetRemoveAllNullFromEmpty() {
}
public void testEntrySetRetainAll() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -717,7 +717,7 @@ public void testEntrySetRetainAll() {
}
public void testEntrySetRetainAllNullFromEmpty() {
- final Map map;
+ Map map;
try {
map = makeEmptyMap();
} catch (UnsupportedOperationException e) {
@@ -743,7 +743,7 @@ public void testEntrySetRetainAllNullFromEmpty() {
}
public void testEntrySetClear() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -765,10 +765,10 @@ public void testEntrySetClear() {
}
public void testEntrySetAddAndAddAll() {
- final Map map = makeEitherMap();
+ Map map = makeEitherMap();
Set> entrySet = map.entrySet();
- final Entry entryToAdd = mapEntry(null, null);
+ Entry entryToAdd = mapEntry(null, null);
try {
entrySet.add(entryToAdd);
fail("Expected UnsupportedOperationException or NullPointerException.");
@@ -793,8 +793,8 @@ public void testEntrySetSetValue() {
return;
}
- final Map map;
- final V valueToSet;
+ Map map;
+ V valueToSet;
try {
map = makePopulatedMap();
valueToSet = getValueNotInPopulatedMap();
@@ -804,8 +804,8 @@ public void testEntrySetSetValue() {
Set> entrySet = map.entrySet();
Entry entry = entrySet.iterator().next();
- final V oldValue = entry.getValue();
- final V returnedValue = entry.setValue(valueToSet);
+ V oldValue = entry.getValue();
+ V returnedValue = entry.setValue(valueToSet);
assertEquals(oldValue, returnedValue);
assertTrue(entrySet.contains(mapEntry(entry.getKey(), valueToSet)));
assertEquals(valueToSet, map.get(entry.getKey()));
@@ -819,7 +819,7 @@ public void testEntrySetSetValueSameValue() {
return;
}
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -828,8 +828,8 @@ public void testEntrySetSetValueSameValue() {
Set> entrySet = map.entrySet();
Entry entry = entrySet.iterator().next();
- final V oldValue = entry.getValue();
- final V returnedValue = entry.setValue(oldValue);
+ V oldValue = entry.getValue();
+ V returnedValue = entry.setValue(oldValue);
assertEquals(oldValue, returnedValue);
assertTrue(entrySet.contains(mapEntry(entry.getKey(), oldValue)));
assertEquals(oldValue, map.get(entry.getKey()));
@@ -837,15 +837,16 @@ public void testEntrySetSetValueSameValue() {
}
public void testEqualsForEqualMap() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
return;
}
- assertEquals(map, map);
- assertEquals(makePopulatedMap(), map);
+ // Explicitly call `equals`; `assertEquals` might return fast
+ assertTrue(map.equals(map));
+ assertTrue(makePopulatedMap().equals(map));
assertFalse(map.equals(Collections.emptyMap()));
// no-inspection ObjectEqualsNull
assertFalse(map.equals(null));
@@ -856,8 +857,8 @@ public void testEqualsForLargerMap() {
return;
}
- final Map map;
- final Map largerMap;
+ Map map;
+ Map largerMap;
try {
map = makePopulatedMap();
largerMap = makePopulatedMap();
@@ -874,8 +875,8 @@ public void testEqualsForSmallerMap() {
return;
}
- final Map map;
- final Map smallerMap;
+ Map map;
+ Map smallerMap;
try {
map = makePopulatedMap();
smallerMap = makePopulatedMap();
@@ -888,15 +889,16 @@ public void testEqualsForSmallerMap() {
}
public void testEqualsForEmptyMap() {
- final Map map;
+ Map map;
try {
map = makeEmptyMap();
} catch (UnsupportedOperationException e) {
return;
}
- assertEquals(map, map);
- assertEquals(makeEmptyMap(), map);
+ // Explicitly call `equals`; `assertEquals` might return fast
+ assertTrue(map.equals(map));
+ assertTrue(makeEmptyMap().equals(map));
assertEquals(Collections.emptyMap(), map);
assertFalse(map.equals(Collections.emptySet()));
// noinspection ObjectEqualsNull
@@ -904,7 +906,7 @@ public void testEqualsForEmptyMap() {
}
public void testGet() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -925,7 +927,7 @@ public void testGet() {
}
public void testGetForEmptyMap() {
- final Map map;
+ Map map;
K unmappedKey = null;
try {
map = makeEmptyMap();
@@ -954,7 +956,7 @@ public void testGetNull() {
}
public void testHashCode() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -964,7 +966,7 @@ public void testHashCode() {
}
public void testHashCodeForEmptyMap() {
- final Map map;
+ Map map;
try {
map = makeEmptyMap();
} catch (UnsupportedOperationException e) {
@@ -974,9 +976,9 @@ public void testHashCodeForEmptyMap() {
}
public void testPutNewKey() {
- final Map map = makeEitherMap();
- final K keyToPut;
- final V valueToPut;
+ Map map = makeEitherMap();
+ K keyToPut;
+ V valueToPut;
try {
keyToPut = getKeyNotInPopulatedMap();
valueToPut = getValueNotInPopulatedMap();
@@ -1002,9 +1004,9 @@ public void testPutNewKey() {
}
public void testPutExistingKey() {
- final Map map;
- final K keyToPut;
- final V valueToPut;
+ Map map;
+ K keyToPut;
+ V valueToPut;
try {
map = makePopulatedMap();
valueToPut = getValueNotInPopulatedMap();
@@ -1033,16 +1035,16 @@ public void testPutNullKey() {
if (!supportsPut) {
return;
}
- final Map map = makeEitherMap();
- final V valueToPut;
+ Map map = makeEitherMap();
+ V valueToPut;
try {
valueToPut = getValueNotInPopulatedMap();
} catch (UnsupportedOperationException e) {
return;
}
if (allowsNullKeys) {
- final V oldValue = map.get(null);
- final V returnedValue = map.put(null, valueToPut);
+ V oldValue = map.get(null);
+ V returnedValue = map.put(null, valueToPut);
assertEquals(oldValue, returnedValue);
assertEquals(valueToPut, map.get(null));
assertTrue(map.containsKey(null));
@@ -1061,8 +1063,8 @@ public void testPutNullValue() {
if (!supportsPut) {
return;
}
- final Map map = makeEitherMap();
- final K keyToPut;
+ Map map = makeEitherMap();
+ K keyToPut;
try {
keyToPut = getKeyNotInPopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1070,8 +1072,8 @@ public void testPutNullValue() {
}
if (allowsNullValues) {
int initialSize = map.size();
- final V oldValue = map.get(keyToPut);
- final V returnedValue = map.put(keyToPut, null);
+ V oldValue = map.get(keyToPut);
+ V returnedValue = map.put(keyToPut, null);
assertEquals(oldValue, returnedValue);
assertNull(map.get(keyToPut));
assertTrue(map.containsKey(keyToPut));
@@ -1091,8 +1093,8 @@ public void testPutNullValueForExistingKey() {
if (!supportsPut) {
return;
}
- final Map map;
- final K keyToPut;
+ Map map;
+ K keyToPut;
try {
map = makePopulatedMap();
keyToPut = map.keySet().iterator().next();
@@ -1101,8 +1103,8 @@ public void testPutNullValueForExistingKey() {
}
if (allowsNullValues) {
int initialSize = map.size();
- final V oldValue = map.get(keyToPut);
- final V returnedValue = map.put(keyToPut, null);
+ V oldValue = map.get(keyToPut);
+ V returnedValue = map.put(keyToPut, null);
assertEquals(oldValue, returnedValue);
assertNull(map.get(keyToPut));
assertTrue(map.containsKey(keyToPut));
@@ -1119,16 +1121,16 @@ public void testPutNullValueForExistingKey() {
}
public void testPutAllNewKey() {
- final Map map = makeEitherMap();
- final K keyToPut;
- final V valueToPut;
+ Map map = makeEitherMap();
+ K keyToPut;
+ V valueToPut;
try {
keyToPut = getKeyNotInPopulatedMap();
valueToPut = getValueNotInPopulatedMap();
} catch (UnsupportedOperationException e) {
return;
}
- final Map mapToPut = Collections.singletonMap(keyToPut, valueToPut);
+ Map mapToPut = Collections.singletonMap(keyToPut, valueToPut);
if (supportsPut) {
int initialSize = map.size();
map.putAll(mapToPut);
@@ -1147,9 +1149,9 @@ public void testPutAllNewKey() {
}
public void testPutAllExistingKey() {
- final Map map;
- final K keyToPut;
- final V valueToPut;
+ Map map;
+ K keyToPut;
+ V valueToPut;
try {
map = makePopulatedMap();
valueToPut = getValueNotInPopulatedMap();
@@ -1157,7 +1159,7 @@ public void testPutAllExistingKey() {
return;
}
keyToPut = map.keySet().iterator().next();
- final Map mapToPut = Collections.singletonMap(keyToPut, valueToPut);
+ Map mapToPut = Collections.singletonMap(keyToPut, valueToPut);
int initialSize = map.size();
if (supportsPut) {
map.putAll(mapToPut);
@@ -1176,8 +1178,8 @@ public void testPutAllExistingKey() {
}
public void testRemove() {
- final Map map;
- final K keyToRemove;
+ Map map;
+ K keyToRemove;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1202,8 +1204,8 @@ public void testRemove() {
}
public void testRemoveMissingKey() {
- final Map map;
- final K keyToRemove;
+ Map map;
+ K keyToRemove;
try {
map = makePopulatedMap();
keyToRemove = getKeyNotInPopulatedMap();
@@ -1229,7 +1231,7 @@ public void testSize() {
}
public void testKeySetRemove() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1254,7 +1256,7 @@ public void testKeySetRemove() {
}
public void testKeySetRemoveAll() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1279,7 +1281,7 @@ public void testKeySetRemoveAll() {
}
public void testKeySetRetainAll() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1303,7 +1305,7 @@ public void testKeySetRetainAll() {
}
public void testKeySetClear() {
- final Map map;
+ Map map;
try {
map = makeEitherMap();
} catch (UnsupportedOperationException e) {
@@ -1325,7 +1327,7 @@ public void testKeySetClear() {
}
public void testKeySetRemoveAllNullFromEmpty() {
- final Map map;
+ Map map;
try {
map = makeEmptyMap();
} catch (UnsupportedOperationException e) {
@@ -1351,7 +1353,7 @@ public void testKeySetRemoveAllNullFromEmpty() {
}
public void testKeySetRetainAllNullFromEmpty() {
- final Map map;
+ Map map;
try {
map = makeEmptyMap();
} catch (UnsupportedOperationException e) {
@@ -1377,8 +1379,8 @@ public void testKeySetRetainAllNullFromEmpty() {
}
public void testValues() {
- final Map map;
- final Collection valueCollection;
+ Map map;
+ Collection valueCollection;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1387,7 +1389,7 @@ public void testValues() {
assertInvariants(map);
valueCollection = map.values();
- final V unmappedValue;
+ V unmappedValue;
try {
unmappedValue = getValueNotInPopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1399,7 +1401,7 @@ public void testValues() {
}
public void testValuesIteratorRemove() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1434,7 +1436,7 @@ public void testValuesIteratorRemove() {
}
public void testValuesRemove() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1460,8 +1462,8 @@ public void testValuesRemove() {
}
public void testValuesRemoveMissing() {
- final Map map;
- final V valueToRemove;
+ Map map;
+ V valueToRemove;
try {
map = makeEitherMap();
valueToRemove = getValueNotInPopulatedMap();
@@ -1485,7 +1487,7 @@ public void testValuesRemoveMissing() {
}
public void testValuesRemoveAll() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1513,7 +1515,7 @@ public void testValuesRemoveAll() {
}
public void testValuesRemoveAllNullFromEmpty() {
- final Map map;
+ Map map;
try {
map = makeEmptyMap();
} catch (UnsupportedOperationException e) {
@@ -1539,7 +1541,7 @@ public void testValuesRemoveAllNullFromEmpty() {
}
public void testValuesRetainAll() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
@@ -1567,7 +1569,7 @@ public void testValuesRetainAll() {
}
public void testValuesRetainAllNullFromEmpty() {
- final Map map;
+ Map map;
try {
map = makeEmptyMap();
} catch (UnsupportedOperationException e) {
@@ -1593,7 +1595,7 @@ public void testValuesRetainAllNullFromEmpty() {
}
public void testValuesClear() {
- final Map map;
+ Map map;
try {
map = makePopulatedMap();
} catch (UnsupportedOperationException e) {
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java
index 7bb418f5a97b..7b8e40a2b1aa 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java
@@ -101,6 +101,8 @@ protected List createDerivedSuites(
.withFeatures(computeReserializedMapFeatures(parentBuilder.getFeatures()))
.named(parentBuilder.getName() + " reserialized")
.suppressing(parentBuilder.getSuppressedTests())
+ .withSetUp(parentBuilder.getSetUp())
+ .withTearDown(parentBuilder.getTearDown())
.createTestSuite());
}
@@ -110,6 +112,8 @@ protected List createDerivedSuites(
.withFeatures(computeEntrySetFeatures(parentBuilder.getFeatures()))
.named(parentBuilder.getName() + " entrySet")
.suppressing(parentBuilder.getSuppressedTests())
+ .withSetUp(parentBuilder.getSetUp())
+ .withTearDown(parentBuilder.getTearDown())
.createTestSuite());
derivedSuites.add(
@@ -117,6 +121,8 @@ protected List createDerivedSuites(
.withFeatures(computeKeySetFeatures(parentBuilder.getFeatures()))
.named(parentBuilder.getName() + " keys")
.suppressing(parentBuilder.getSuppressedTests())
+ .withSetUp(parentBuilder.getSetUp())
+ .withTearDown(parentBuilder.getTearDown())
.createTestSuite());
derivedSuites.add(
@@ -125,6 +131,8 @@ protected List createDerivedSuites(
.named(parentBuilder.getName() + " values")
.withFeatures(computeValuesCollectionFeatures(parentBuilder.getFeatures()))
.suppressing(parentBuilder.getSuppressedTests())
+ .withSetUp(parentBuilder.getSetUp())
+ .withTearDown(parentBuilder.getTearDown())
.createTestSuite());
return derivedSuites;
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/MinimalCollection.java b/android/guava-testlib/src/com/google/common/collect/testing/MinimalCollection.java
index a6ec93d1eca3..2adf0725147d 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/MinimalCollection.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/MinimalCollection.java
@@ -33,12 +33,12 @@ public class MinimalCollection extends AbstractCollection {
// TODO: expose allow nulls parameter?
public static MinimalCollection of(E... contents) {
- return new MinimalCollection(Object.class, true, contents);
+ return new MinimalCollection<>(Object.class, true, contents);
}
// TODO: use this
public static MinimalCollection ofClassAndContents(Class type, E... contents) {
- return new MinimalCollection(type, true, contents);
+ return new MinimalCollection<>(type, true, contents);
}
private final E[] contents;
diff --git a/android/guava-testlib/src/com/google/common/collect/testing/MinimalIterable.java b/android/guava-testlib/src/com/google/common/collect/testing/MinimalIterable.java
index c151c15e1319..15d48dbbd75b 100644
--- a/android/guava-testlib/src/com/google/common/collect/testing/MinimalIterable.java
+++ b/android/guava-testlib/src/com/google/common/collect/testing/MinimalIterable.java
@@ -51,7 +51,7 @@ public final class MinimalIterable implements Iterable {
/** Returns an iterable whose iterator returns the given elements in order. */
public static MinimalIterable