Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JourneyMap missing some mob icons #36

Open
2 tasks done
ejm554 opened this issue Nov 23, 2022 · 2 comments
Open
2 tasks done

JourneyMap missing some mob icons #36

ejm554 opened this issue Nov 23, 2022 · 2 comments

Comments

@ejm554
Copy link
Owner

ejm554 commented Nov 23, 2022 •
edited
Loading

Overview

  • JourneyMap can display mob icons on its main and mini maps.
  • The mod is not displaying icons for many of the other custom mods, such as the Goblin Trader.
  • Users can add these icons by creating custom resource packs, as described in this (archived) documentation.

To Do

  • Try creating & testing a simple resource pack with only one or two mods.
  • Download the icon set in resourcepack that adds icons to Xaero's Map (here).
ejm554 added a commit that referenced this issue Nov 23, 2022
@ejm554
feat: add custom resourcepack
d926e98 
Refer to:
- Issue #36: JourneyMap missing some mob icons

Summary:
- Add Goblin Trader icon to JourneyMap.
@ejm554
Copy link
Owner Author

ejm554 commented Nov 28, 2022

  • The resource pack was successfully created and tested.
  • And icon for the Goblin Traders was added and confirmed to be visible on the map.
    • This particular icon was for testing only, and it should be replaced by the one contained in the mod's jar file.
    • For details, see Task list for version 2.0.0 #37

image

ejm554 added a commit that referenced this issue Nov 28, 2022
@ejm554
feat!: add resourcepack
d570778 
Summary:
- Add a custom resourcepack.
- Add non-Vanilla icon (Goblin Traders), via the resourcepack, that work
with JourneyMap's mob feature.

Refer to:
- Issue #36: JourneyMap missing some mob icons
ejm554 added a commit that referenced this issue Nov 28, 2022
@ejm554
feat: add resourcepack
4de7fc8 
Summary:
- Add a custom resourcepack.
- Add non-Vanilla icon (Goblin Traders), via the resourcepack, that work
with JourneyMap's mob feature.

Refer to:
- Issue #36: JourneyMap missing some mob icons

Compatibility info:
- Breaking changes should NOT result from this commit.
@ejm554 ejm554 mentioned this issue Nov 30, 2022
Open
11 tasks
@ejm554
Copy link
Owner Author

ejm554 commented Nov 30, 2022

Source for Goblin Trader:
.minecraft\mods\goblintraders-1.8.0-1.18.2.jar/assets/goblintraders/textures/entity/goblin_trader.png

Source for other mods: Xaero's Minimap - Modded Support

JourneyMap mob-icon instructions

@ejm554 ejm554 mentioned this issue Nov 30, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ejm554