Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for the title text to be removed #1269

Open
oas777 opened this issue Oct 30, 2024 · 4 comments
Open

Allow for the title text to be removed #1269

oas777 opened this issue Oct 30, 2024 · 4 comments
Labels
next-breaking-change Things that should be released with the next breaking-change release
Milestone

Comments

@oas777
Copy link
Collaborator

oas777 commented Oct 30, 2024

In case you have the name/title of your video site in the logo and want to have a video on top.

image

@LukasKalbertodt LukasKalbertodt added the next-breaking-change Things that should be released with the next breaking-change release label Nov 4, 2024
@dagraf
Copy link
Collaborator

dagraf commented Nov 12, 2024

+1

Same here in Bern.

Bildschirmfoto 2024-11-12 um 16 38 43

@LukasKalbertodt
Copy link
Member

To reduce bloating the configuration too much, I would probably remove this text in 3.0 completely. We only need to provide a way for people to "get that title back" if they want. I see two options:

  1. We make it possible to give a name to the root realm (like any other realm).
  2. We solve it via "Title" blocks.

I think I slightly prefer 1, without having thought about it too much. For all other realms, the name is already rendered as a <h1> element, which is exactly what we want. It would also make the root realm less special, and fewer special cases are always good (note though that the root realm is still special as a null name is allowed, unlike for other realms).
Title blocks are currently rendered as <h2> elements, but having those without a <h1> is not great, so we would need to special case "the first title block on the root realm"... which adds special treatment.

@LukasKalbertodt LukasKalbertodt added this to the v3.0 milestone Nov 13, 2024
@dagraf
Copy link
Collaborator

dagraf commented Nov 18, 2024

I also prefer 1. Like this, we will have a consistent behavior.

@oas777
Copy link
Collaborator Author

oas777 commented Nov 18, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-breaking-change Things that should be released with the next breaking-change release
Projects
None yet
Development

No branches or pull requests

3 participants