Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for logo to switch with language switch #1271

Closed
oas777 opened this issue Nov 4, 2024 · 1 comment
Closed

Allow for logo to switch with language switch #1271

oas777 opened this issue Nov 4, 2024 · 1 comment
Assignees
@owi92
Labels
next-breaking-change Things that should be released with the next breaking-change release
Milestone
v3.0

Comments

@oas777
Copy link
Collaborator

oas777 commented Nov 4, 2024

In case you have a logo in two languages like ETH does.
@LukasKalbertodt LukasKalbertodt added the next-breaking-change Things that should be released with the next breaking-change release label Nov 4, 2024
@LukasKalbertodt LukasKalbertodt added this to the v3.0 milestone Nov 13, 2024
@owi92 owi92 self-assigned this Nov 29, 2024
@owi92 owi92 mentioned this issue Dec 9, 2024
Merged
LukasKalbertodt added a commit that referenced this issue Jan 14, 2025
@LukasKalbertodt
Allow configuring logos for multiple languages (#1292)
3b99648 
This will make it possible to configure logos for any number of
languages (though for now, Tobira only knows what to do with english,
german and non-language-specific logos).

This is a breaking change, as it changes the way logo files are
configured. Previous configurations won't work anymore.
Specifics and examples for the new configuration will be available in
our docs.

Closes #1271
@owi92
Copy link
Member

owi92 commented Jan 14, 2025

Fixed via #1292

@owi92 owi92 closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owi92 owi92

Labels
next-breaking-change Things that should be released with the next breaking-change release
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@oas777 @LukasKalbertodt @owi92