Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Stop overriding default jvm.options file #738

Open
jmlrt opened this issue Oct 30, 2020 · 9 comments
Open

Stop overriding default jvm.options file #738

jmlrt opened this issue Oct 30, 2020 · 9 comments

Comments

@jmlrt
Copy link
Member

jmlrt commented Oct 30, 2020

This role is currently using jvm.options.j2 template to override the default config/jvm.options file provided by Elasticsearch package.

Maintaining this template to keep default options from the file provided by Elasticsearch package for every version while allowing to change some specific options is really painful.

Since 7.7.0, Elasticsearch allow to add override options in config/jvm.options.d/ and instead of modifying default config/jvm.options.

Adding support for it in ansible-elasticsearch role would allow us to remove the jvm.options.j2 template and use the default options file provided by Elasticsearch instead while allowing more flexibility in what users can override.

@botelastic
Copy link

botelastic bot commented Jan 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jmlrt
Copy link
Member Author

jmlrt commented Jan 28, 2021

still valid

@botelastic
Copy link

botelastic bot commented Apr 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jmlrt
Copy link
Member Author

jmlrt commented May 10, 2021

still valid

@botelastic botelastic bot removed the triage/stale label May 10, 2021
@botelastic
Copy link

botelastic bot commented Aug 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic
Copy link

botelastic bot commented Sep 7, 2021

This issue has been automatically closed because it has not had recent activity since being marked as stale.

@botelastic botelastic bot closed this as completed Sep 7, 2021
@jmlrt jmlrt reopened this Sep 7, 2021
@botelastic botelastic bot removed the triage/stale label Sep 7, 2021
@botelastic
Copy link

botelastic bot commented Dec 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jmlrt
Copy link
Member Author

jmlrt commented Dec 6, 2021

still valid

@botelastic botelastic bot removed the triage/stale label Dec 6, 2021
@botelastic
Copy link

botelastic bot commented Jun 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant