-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle exceptions correctly if native function throws exception #896
Open
SergeyKleyman
wants to merge
10
commits into
elastic:main
Choose a base branch
from
SergeyKleyman:SDH_873_failed_to_call_post_hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Handle exceptions correctly if native function throws exception #896
SergeyKleyman
wants to merge
10
commits into
elastic:main
from
SergeyKleyman:SDH_873_failed_to_call_post_hook
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix MemoryTracker reported all the allocated blocks even when the leak was detected for the request-scoped allocations
…e than once Fixed memory leak for the case when legacy PHP error is triggered more than once - pointer to allocated memory for previous error data is overwritten without freeing it first.
intuibase
approved these changes
Mar 22, 2023
run docs-build |
intuibase
changed the title
Skip post-hook if instrumented function has thrown
Handle exceptions correctly if native function throws exception
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zend's
call_user_function
returns failure whenEG(exception) != NULL
so we cannot call instrumentation post-hook if the original handler exited by exception.