-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for otlp endpoints #18
Comments
Do we want a boolean switch (sending either Elastic APM or OTLP) or an enable switch (sending Elastic APM only or both Elastic APM and OTLP)? In case is the first occurrence, would we prefer:
Does |
Sorry the description was unclear. apmsoak uses a scenarios file to send load to the intake api. Each scenario can be customized by tuning specific settings: apm-perf/internal/soaktest/scenario.go Lines 11 to 27 in 83d2b40
Among those there is AFAIK the events are hardcoded in the repository in |
It make sense, but were you thinking of supporting both OTLP via HTTP and gRPC? I briefly looked at the code but it seems it is HTTP oriented so supporting gRPC would require more adjustments. The main reason I'm thinking we need gRPC too is that if the purpose of the test is to create constant load we can observe differences between HTTP and gRPC that we are probably interested in. |
That's a good point! I was initially thinking of otlp via HTTP but we could add gRPC too. I think HTTP should be enough/minimum for our purpose and then we can iterate and add gRPC in a followup issue to avoid growing the scope of this issue too much. WDYT ? |
Agree, let's start with HTTP and scope this task to OTLP over HTTP. |
I started working on this again, following @kruskall suggestion. |
The initial effort in #45 using otlp/http in JSON protobuf encoding is blocked by elastic/apm-server#12636 . It may be better to evaluate alternative tools like https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/telemetrygen |
#58 addressed this partially. Support for apmsoak is still missing. |
The soaktest runner sends events to the intake v2 endpoints and is able to generate load from the major agents however there's no option to send events to the otlp endpoint.
We should add support for that
The text was updated successfully, but these errors were encountered: