Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] [Heartbeat] Explore implementing timeout for browser monitors #29454

Closed
dominiqueclarke opened this issue Dec 15, 2021 · 6 comments
Closed
Labels
enhancement Heartbeat Stalled Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@dominiqueclarke
Copy link

Heartbeat exposes a timeout field for monitor types. However, browser monitors do not currently support timeout and the value is ignored

We should consider implementing timeout for browser monitors, and the side-effects of doing so. In particular, we will need to determine how this logic ought to behave for both inline and zip URL monitors.

@dominiqueclarke dominiqueclarke added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Dec 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@andrewvc
Copy link
Contributor

Building this correctly for inline monitors is pretty straightforward, it's a bit more complex for suites.

I propose the following:

  1. We parallelize all suite jobs, to run all journeys simultaneously
  2. We stagger the jobs by consistently hashing their journey names to run at offsets to prevent them all running at the same time, thus spreading them out over their test interval. This prevents the problem we currently have, where serially executed journeys can delay the start of one after (head of line blocking).
  3. We add the timeout value to these individual jobs
  4. After each job we send a new suite status doc per [Heartbeat] [Browser Monitor] Bubble Errors up in browser source configuration to be viewable in places like Kibana #27924 (comment), rather than waiting till the end of the run, the suite statuses are updated once per journey completion

@vigneshshanmugam
Copy link
Member

All of this states we need ahead of time compilation for the HB especially for suites, haven't thought about how we would do this.

@emilioalvap
Copy link
Collaborator

@dominiqueclarke @andrewvc with zip url and suites being deprecated, is this still a requirement?
We already have issues for timeouts to be supported at project level

@botelastic
Copy link

botelastic bot commented Oct 7, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 7, 2023
@paulb-elastic
Copy link
Contributor

Captured in elastic/synthetics#133, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Stalled Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

No branches or pull requests

6 participants