Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netflow v9 decoder lint error deserves a look #42790

Open
jrmolin opened this issue Feb 19, 2025 · 1 comment
Open

Netflow v9 decoder lint error deserves a look #42790

jrmolin opened this issue Feb 19, 2025 · 1 comment
Labels
Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution

Comments

@jrmolin
Copy link
Contributor

jrmolin commented Feb 19, 2025 •
edited
Loading

x-pack/filebeat/input/netflow/v9/decoder.go

          > error is not nil (line 159) but it returns nil (nilerr)

This linter warning ... does look like a real problem whereby we are ignoring an error.

Originally posted by @andrewkroh in #42704 (comment)

The Netflow v9 decoder breaks out of a loop when an error is encountered, but it does not return that error.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 19, 2025
@jrmolin jrmolin changed the title > error is not nil (line 159) but it returns nil (nilerr) Netflow v9 decoder lint error deserves a look Feb 19, 2025
@jrmolin jrmolin added the Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution label Feb 19, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 19, 2025
@jrmolin jrmolin mentioned this issue Feb 19, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrmolin @elasticmachine