-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filebeat] Introduce otel mode #41849
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Overall looks good. Just need to address lint failures and handle errors. |
Co-authored-by: Vihas Makwana <[email protected]>
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
So, it was indeed a flaky test. CI is passing now. |
Thank you for taking a look! |
This pull request is now in conflicts. Could you fix it? 🙏
|
How much larger does including this make the Filebeat and Agentbeat binaries on disk? |
Before and After including this changeset in filebeat
In Agentbeat
|
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good.
Couple questions below.
One Nit, can we avoid "otelcommon" as a package name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow on, I'd like to see an integration test that runs filebeat with a config that writes an event to elasticsearch, then run the same config with the otel command to prove that the converted config functions as intended. Test could use benchmark input and mock-es for the elasticsearch.
@leehinman the tests you described are a part of the follow up ticket here https://github.com/elastic/ingest-dev/issues/4595 Feel free to comment on the ticket if we missed something. |
To note
libbeat/otelcommon/
libbeat/outputs/${output_type}
elasticsearch
is configuredElasticsearch paramaters that are currently unsupported
and some TLS paramaters that are currently not supported
The change in filebeat and agentbeat binary sizes before and after this changeset is as follows
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally