Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17](backport #42012) [filebeat][streaming] - Added default values for websocket retries & put a cap on waitTime to be <= waitMax #42030

Merged
merged 2 commits into from
Dec 13, 2024
Merged

[8.17](backport #42012) [filebeat][streaming] - Added default values for websocket retries & put a cap on waitTime to be <= waitMax #42030

merged 2 commits into from
Dec 13, 2024
+13 −3

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2024

Type of change

  • Enhancement

Proposed commit message

Added default values for websocket retries & put a cap on waitTime to be <= waitMax. Updated the documentation accordingly. Capping the waitMax value avoids long/indefinite wait times that can be caused due to backoff calculation.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #42012 done by [Mergify](https://mergify.com).

@ShourieG @mergify
[filebeat][streaming] - Added default values for websocket retries & …
27864b4 
…put a cap on waitTime to be <= waitMax (#42012)

* added default retry values and ensured a cap on waitTime i.e now waitTime <= wait_max

* updated changelog

(cherry picked from commit 5ed055b)
@mergify mergify bot requested a review from a team as a code owner December 13, 2024 09:36
@mergify mergify bot added the backport label Dec 13, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 13, 2024
@botelastic
Copy link

botelastic bot commented Dec 13, 2024

This pull request doesn't have a Team:<team> label.

@ShourieG ShourieG merged commit 9ea9d46 into 8.17 Dec 13, 2024
22 checks passed
@ShourieG ShourieG deleted the mergify/bp/8.17/pr-42012 branch December 13, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@ShourieG ShourieG

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ShourieG