Leaking cancel contexts.

[urso]

The client uses WithContext to create a context for signaling shutdown to sub go-routines. This seems to make the context leak when the workers return without cancelling the context. The cancel function must be run always.

It seams the context that is generated on 'Start' is leaked at least if the Dial fails. The workaround is to call Stop always. There or other contexts that are generated via WithCancel, that look suspiciously like leaks, but I didn't check if that is the case.

[ph]

@blakerouse @michalpristas we probably have a leak?

[michalpristas]

oh this one's sitting here for a while. we can plan it for this release, seems like easy fix
wdyt @ph

[ph]

I will mark it for 7.11, the fix is easy but there are multiple PR involved.