Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #292 #293

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Fixes #292 #293

merged 3 commits into from
Mar 10, 2025
+11 −6

Conversation

khushijain21
Copy link
Contributor

What does this PR do?

The diagError method expects the error message to have exact match. This is not always true.
This change matches the subset of the error using strings.Contains method.

It was locally tested to work using

go run golang.org/x/tools/cmd/stress@latest ./httpcommon.test -test.run Test_diagError -test.v

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

Related issues

@khushijain21 khushijain21 requested a review from a team as a code owner March 6, 2025 09:17
@khushijain21 khushijain21 requested review from mauri870 and VihasMakwana and removed request for a team March 6, 2025 09:17
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 7, 2025
mauri870
mauri870 previously approved these changes Mar 7, 2025
View reviewed changes
@khushijain21 @mauri870
Update transport/httpcommon/diag.go
aacec88 
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
@khushijain21 khushijain21 enabled auto-merge (squash) March 10, 2025 08:22
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@khushijain21 khushijain21 merged commit f003159 into elastic:main Mar 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauri870 mauri870 mauri870 approved these changes

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky Test] Test_diagError/Server_requires_client_auth
4 participants
@khushijain21 @elasticmachine @mauri870 @pierrehilbert