for sure close the reader

elastic · Feb 23, 2024 · 0689096 · 0689096
1 parent 6351f69
commit 0689096
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/internal/pkg/agent/storage/store/migrations.go b/internal/pkg/agent/storage/store/migrations.go
@@ -112,16 +112,12 @@ func migrateYAMLStateStoreToStateStoreV1(store storage.Storage) error {
 	}
 
 	st, err := readState(reader)
+	defer reader.Close()
 	if err == nil {
 		// it's a valid JSON, therefore nothing to migrate
 		return nil
 	}
 
-	err = reader.Close()
-	if err != nil {
-		return fmt.Errorf("could not close store reader: %w", err)
-	}
-
 	// Try to read the store as YAML
 	yamlStore, err := migrations.LoadYAMLStateStore(store)
 	if err != nil {