Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent/beats gRPC over domain sockets/named pipes #4899

Open
aleksmaus opened this issue Jun 10, 2024 · 4 comments
Open

Agent/beats gRPC over domain sockets/named pipes #4899

aleksmaus opened this issue Jun 10, 2024 · 4 comments
Assignees
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@aleksmaus
Copy link
Member

Describe the enhancement:

Change the Agent/Beats gRPC communication to utilize domain sockets/named pipes.

This is to follow up on the initial feature request:
Agent/beats grpc comms over domain socket/named pipe

Done:

The initial implementation with Agent/beats grpc comms over domain socket/named pipe PR was scaled back due to lack of support for gRPC over domain sockets/named pipes by the underlying library that Endpoint uses for comms. The scope of this change was limited to switching to domain socket/named pipe for connection information discovery only, for 8.15 release.

  • The elastic-agent-client library was updated in order to support comms over domain socket/named piped: Add domain socket/named pipe support elastic-agent-client#91

  • The Endpoint spec was enhanced with csocket configuration that defines the domain socket file name relative to the Agent install directory on non-Windows OS or the named pipe name on Windows.

  • The Endpoint was modified to connect to the specified domain socket/named pipe for the connection information discovery.

  • The code for domain sockets/named pipes gRPC comms was disabled in Agent/beats grpc comms over domain socket/named pipe #4249

TODO:

  • Endpoint to implement gRPC comms over domain sockets/named pipes support. There are plans to replace/rewrite the existing gRPC comms.
  • Enable the Agent code for domain sockets/named piped gPRC, that was disabled here 0b8ca7b

Describe a specific use case for the enhancement or feature:

There were few SDH related to the fact that the current GRPC comms are over IP socket and ask for ability to use domain socket/named pipe instead.

What is the definition of done?

Agent can communicate with Beats and Security Endpoint over domain sockets/named pipes.

@aleksmaus aleksmaus self-assigned this Jun 10, 2024
@cmacknz cmacknz added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@nimarezainia
Copy link
Contributor

  • Endpoint to implement gRPC comms over domain sockets/named pipes support. There are plans to replace/rewrite the existing gRPC comms.

@aleksmaus Would you have an issue for this work on the Defend team that we could track?

@aleksmaus
Copy link
Member Author

I know that @jrmolin has gRPC comms rewrite in Rust for Endpoint. Mo, do you have a tracker for that?

@nfritts
Copy link

nfritts commented Aug 22, 2024

@nimarezainia I don't think there's currently a public issue for it, but the work is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

5 participants