Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11](backport #3626) Add component.{id, binary} to monitoring metrics #3708

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 6, 2023

This is an automatic backport of pull request #3626 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

This commit adds `component.id` and `component.binary` to the
monitoring metrics, those fields are necessary to create unique TSDB
entries.

(cherry picked from commit c4462d2)
@mergify mergify bot requested a review from a team as a code owner November 6, 2023 07:47
@mergify mergify bot added the backport label Nov 6, 2023
@mergify mergify bot requested review from AndersonQ and blakerouse and removed request for a team November 6, 2023 07:47
Copy link
Contributor Author

mergify bot commented Nov 6, 2023

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

Copy link

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-06T07:47:22.935+0000

  • Duration: 26 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 6505
Skipped 59
Total 6564

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.81% (83/84) 👍
Files 66.556% (201/302) 👍
Classes 65.419% (367/561) 👍
Methods 52.869% (1161/2196) 👍
Lines 39.265% (13585/34598) 👍 0.059
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert requested review from belimawr and removed request for AndersonQ and blakerouse November 6, 2023 08:38
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@belimawr belimawr merged commit 6008507 into 8.11 Nov 7, 2023
10 checks passed
@belimawr belimawr deleted the mergify/bp/8.11/pr-3626 branch November 7, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants