From 71f9b271f31f6407d8a76a5896dfda13e0348549 Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Tue, 10 Dec 2024 18:12:10 -0800 Subject: [PATCH] drop a TODOne --- .github/workflows/test-instrumentation-openai.yml | 3 ++- packages/instrumentation-openai/test/fixtures.test.js | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-instrumentation-openai.yml b/.github/workflows/test-instrumentation-openai.yml index 01a208c1..47a862ad 100644 --- a/.github/workflows/test-instrumentation-openai.yml +++ b/.github/workflows/test-instrumentation-openai.yml @@ -87,7 +87,8 @@ jobs: working-directory: packages/instrumentation-openai - run: npm run compile working-directory: packages/instrumentation-openai - - run: | + - name: Integration tests + run: | set -a; source ./ollama.env npm run test:integration working-directory: packages/instrumentation-openai diff --git a/packages/instrumentation-openai/test/fixtures.test.js b/packages/instrumentation-openai/test/fixtures.test.js index 9e2718f8..6179b5f2 100644 --- a/packages/instrumentation-openai/test/fixtures.test.js +++ b/packages/instrumentation-openai/test/fixtures.test.js @@ -1312,7 +1312,6 @@ test('fixtures', async suite => { }, }, - // TODO: tests with captureMessageContent=false // TODO: see Python's test_all_the_client_options, do something similar // TODO: test with a tool response from user after a tool call (to test https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-events.md#tool-event) // TODO: test a case where stream fails before completion: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-events.md#choice-event says SHOULD have an event with truncated content and finish_reason=error