Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system tests] run validation based on fields along with the mappings one - DO NOT MERGE #2381

Draft
wants to merge 62 commits into
base: main
Choose a base branch
from
Draft

[system tests] run validation based on fields along with the mappings one - DO NOT MERGE #2381

wants to merge 62 commits into from

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jan 29, 2025

Relates #2341

Ensure that validation based on fields (as it is done currently), it is also executed when validation based on mappings is enabled.

The approach to enable validation based on mappings keeps the same:

elastic-package stack up -v -d

export ELASTIC_PACKAGE_FIELD_VALIDATION_TEST_METHOD=mappings
elastic-package test system

elastic-package stack down -v

mrodm added 30 commits December 16, 2024 19:15
@mrodm
Add dynamic templates as parameter
2c3f76e
@mrodm
Add validation for each dynamic template depending on the parameters
41d7b88
@mrodm
Fixes for dynamic templates
ff5298e
@mrodm
Compare fields with dynamic templates
af04d66
@mrodm
Remove multi_fields from flattened fields
f21c712 
multi_fields are now compared directly with dynamic templates or ECS
fields. It was required to know whether or not that field was a
multi_field or not to apply some specific validations.
@mrodm
Test without filtering dynamic templates
aa28db6
@mrodm
Ensure properties subfields are validated accordingly
3767111
@mrodm
Restore filtering and add tests
9fb80b4
@mrodm
Disable unmatch_mapping_type and match_mapping_type and continue look…
2ad28ac 
…ing for other dynamic templates if parameters do not match
@mrodm
Merge upstream/main into validate-dynamic-mappings
8bdad65
@mrodm
Refactors and remove log statements
151e59e
@mrodm
Fix function naming
d0ff6b9
@mrodm
Add test with match_pattern regex
b474b4b
@mrodm
Add comment in tests
066b5a0
@mrodm
Remove loading schema from create validator for mappings method
a7eb191
@mrodm
Separate parsing and validation of dynamic templates
7666ac2
@mrodm
Support match_pattern for the other settings
a718796
@mrodm
fix test
0a5e775
@mrodm
Update tests for multi-fields
131cc9c
@mrodm
Review multi-fields logic
38db8df
@mrodm
Revisit multi-fields logic in ECS
9ff3d0c
@mrodm
Report all errors related to multi-fields comparing with ECS
5165612
@mrodm
Ignored validation of multi-fields with ECS
ce557c9
@mrodm
Fix multi-field test
ebda859
@mrodm
Rephrase errors
019ffd4
@mrodm
Validate fully dynamic objects (preview) with dynamic templates
8f36c18
@mrodm
Rephrase debug message
d96ffbf
@mrodm
Add logging - to be removed
dbca4fe
@mrodm
Merge remote-tracking branch 'upstream/main' into validate-dynamic-ma…
8fce0ec 
…ppings
@mrodm
Validate transforms with mappings getting docs
aa5674f
mrodm added 19 commits January 17, 2025 23:22
@mrodm
Sanitize values read for dynamic templates
9a0b677
@mrodm
Move check for empty strings to elasticsearch functions
ebdd98c
@mrodm
Merge upstream/main into validate-transforms-mappings
4d1724e
@mrodm
Remove unused field
b9917fd
@mrodm
Update stop condition in transforms
9251224
@mrodm
Update sync.time.field setting in transform - ti_anomali
c50b94d
@mrodm
Deleted undesired empty lines
ffcad91
@mrodm
Fix stop conditions to wait for docs in transforms
460b420
@mrodm
Add transform name to test case
1cbe763
@mrodm
Extract function to validate transforms based on mappings
930bbbe
@mrodm
Remove TODO
e2eee93
@mrodm
Use processed docs as stop condition in transforms
a178a68
@mrodm
Remove unused function
aff903b
@mrodm
Add exception for transforms in stacks < 8.14.0
c385cb2 
Do not validate transform fields based on mappings for those packages
where the kibana version is lower than 8.14.0. There is an known issue
related to how mappings are generated.
Related issue: elastic/kibana#175331
@mrodm
Merge upstream/main into validate-transforms-mappings
df0732a
@mrodm
Check for errors in docs when validation based on mappings is used
a65efc3
@mrodm
Rename function
1e5a7ae
@mrodm
Report any mapping error or any doc with an error
afac6f3
@mrodm
Run field validation always
ae36589
@mrodm mrodm self-assigned this Jan 29, 2025
@mrodm mrodm mentioned this pull request Jan 29, 2025
Open
@mrodm mrodm changed the title [system tests] run validation based on fields along with the mappings one [system tests] run validation based on fields along with the mappings one - DO NOT MERGE Feb 5, 2025
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 25, 2025 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @mrodm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mrodm mrodm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrodm @elasticmachine