Skip to content

Prepare JS client 9.0 #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 8 tasks
JoshMock opened this issue Nov 5, 2024 · 7 comments
Closed
5 of 8 tasks

Prepare JS client 9.0 #2433

JoshMock opened this issue Nov 5, 2024 · 7 comments
Assignees
Labels

Comments

@JoshMock
Copy link
Member

JoshMock commented Nov 5, 2024

  • generate alpha that drops typesWithBody for Kibana team to try out
  • change default timeout/keepalive settings to reflect Elasticsearch best practices
  • merge serverless into stack
  • publish as ESM, either by default or as an alternative option
  • migrate type definitions into their relevant API files (still TBD if effort is worth the value)
  • write codemods to support migration away from body prop and any other breaking changes
  • get all docs up to date with the Markdown conversion
  • ensure 9.0 changelog is accurate and up to date
@JoshMock JoshMock self-assigned this Nov 5, 2024
@JoshMock
Copy link
Member Author

JoshMock commented Dec 10, 2024

I've published a 9.0.0-alpha.1 release to npm that drops body param support, and have passed that info to the Kibana core team to help them start planning their upgrade to the 9.0 client.

That client upgrade may not happen until after Kibana 9.0 is released, just given the amount of work it would require before the upcoming feature freeze.

@JoshMock
Copy link
Member Author

Dropping default 30-second timeout on all HTTP requests is done in elastic/elastic-transport-js#201.

@JoshMock
Copy link
Member Author

Client changes necessary to support dropping the default timeout value are in #2573.

@JoshMock
Copy link
Member Author

Changes to the original plan to drop the body parameter are being discussed with the Elastic breaking changes committee, in part due to the discovery documented in #2584.

@JoshMock
Copy link
Member Author

This work is currently blocked by #2605

@JoshMock
Copy link
Member Author

#2605 is resolved, and the changes necessary to resolve #2584 has been merged and published in 9.0.0-alpha.4.

With that change merged, codemods are probably not a necessary thing to provide for the 8-to-9 client migration, since the impact of the breaking change is now much smaller.

@JoshMock
Copy link
Member Author

JoshMock commented Apr 7, 2025

9.0.0-alpha.5 published on Friday and all seems well.

Everything is ready to go for 9.0.0 GA tomorrow, and codegen has been re-run for 9.0 to reflect all the latest changes.

@JoshMock JoshMock closed this as completed Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant