Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.15.6 - Make public SortOptions.AdditionalPropertyName #8335

Open
Tracked by #8356
niemyjski opened this issue Sep 5, 2024 · 2 comments
Open
Tracked by #8356

8.15.6 - Make public SortOptions.AdditionalPropertyName #8335

niemyjski opened this issue Sep 5, 2024 · 2 comments
Labels
8.x Relates to 8.x client version Area: Client Usability

Comments

@niemyjski
Copy link
Contributor

Elastic.Clients.Elasticsearch version: 8.15.6

Elasticsearch version: 8.15.1

.NET runtime version: 8.x

Operating system version: Any

Description of the problem including expected versus actual behavior:

Previously SortOptions was FieldSort and we used the SortKey in our Foundatio.Parsers visitors (https://github.com/FoundatioFx/Foundatio.Parsers/blob/main/src/Foundatio.Parsers.ElasticQueries/Visitors/GetSortFieldsVisitor.cs#L21). This was converted to SortOptions but now we don't have access to the new property value which exposes the field being sorted on (AdditionalPropertyName)... We have our own apis to build up sorting via fluent ui and translate that to your search descriptors.

Expected behavior

We should be able to see how SortOptions are sorted...

Reference: FoundatioFx/Foundatio.Parsers#84

@flobernd
Copy link
Member

flobernd commented Sep 6, 2024

Hi @niemyjski,

I don't want to expose the AdditionalPropertyName field for the reasons I stated in the other issue.

However, we can happily add a SortKey property that just reflects the value of the internal AdditionalPropertyName field.

@niemyjski
Copy link
Contributor Author

That would solve this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Relates to 8.x client version Area: Client Usability
Projects
None yet
Development

No branches or pull requests

2 participants