Should the BasicTable overflow action menu allow for customization? #4326
-
We've run into a situation where we have a few action items and, as determined by the EUI component, a 'more actions' button displays. The auto-rendering of the overflow menu in itself is good but the repeating of the edit action is, at times, undesirable (see comment here). I've not dug into this thoroughly, but as I understand it, we cannot control exactly what displays in the popover / more actions menu. In this particular case, the suggestion was to not show the edit action again; however, all actions appear in the menu. I suspect there is good reason for this behavior that is possibly related to accommodating smaller screens. Is that correct? and if so, could that be adjusted for larger screens (to not automatically include all links / the That may be tricky, but we thought it was worth proposing and, if nothing else, capturing the history/context for this design decision. Current PR implementation (screenshot)Edit (pencil) shows as both a primary action and repeats in the popover menu Proposed design (mockup)Edit (pencil) only shows as a primary action, not in the popover menu |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
The reason all actions are listed in this popover is not just for small screens. It's also really for any one, possibly using assistive tech, that can't reach buttons that only appear on hover. I also wouldn't assume that all the users actually see that initial icon-only action. You could always place the repeated action further down the list. I don't think it has to be first. |
Beta Was this translation helpful? Give feedback.
The reason all actions are listed in this popover is not just for small screens. It's also really for any one, possibly using assistive tech, that can't reach buttons that only appear on hover. I also wouldn't assume that all the users actually see that initial icon-only action. You could always place the repeated action further down the list. I don't think it has to be first.