[EuiIcon] Remove size 's' (12px) #8131
Unanswered
ryankeairns
asked this question in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Teams working on Discover have received feedback that some icons are too small. Namely, the actions in Discover's data grid table. This has evolved into a larger question whether
s
(12px) sized icons are too small in general and should be removed as an option onEuiIcon
.Impact
Supposing we were aligned on removing this size, what would be the impact to the largest consumers?
Kibana
On a quick scan with this regrex
<EuiIcon[ \w=\{\}>\(\)\n;".-:]* size="s"
,I see just over 200 instances of
<EuiIcon ... size=-"s"...
EUI
Small size icons are not simply for bespoke use. They are used in other EUI components such as...
Alternatives
s
size and adapt impacted EUI componentss
size for EuiIcon but somehow keep the size in play for EUI components (so they don't have to be updated)Beta Was this translation helpful? Give feedback.
All reactions