Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Improve error message for expired certificate authority #2447

Closed
kpollich opened this issue Mar 20, 2023 · 7 comments
Closed

[Fleet] Improve error message for expired certificate authority #2447

kpollich opened this issue Mar 20, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers Team:Fleet Label for the Fleet team

Comments

@kpollich
Copy link
Member

Currently, providing an expired certificate authority for Fleet Server, Logstash, etc will report a generic Unknown Certificate Authority error. It'd be ideal if we could detect the expiration case explicitly and provide a more specific error message.

@kpollich kpollich added the Team:Fleet Label for the Fleet team label Mar 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang
Copy link

@kpollich Should we move this to fleet-server repo too?

@kpollich
Copy link
Member Author

I think this one should stay in Kibana because we report the error message in the UI if I'm understanding the issue correctly.

@jen-huang
Copy link

@kpollich My understanding of the SDH is that the error was reported in the CLI when attempting to set up the Fleet Server.

There wouldn't be a way of auditing the certs on the Kibana side since the params point to directories on the host machine.

@kpollich
Copy link
Member Author

Ah I misunderstood the initial SDH then. I'll transfer this now 😄

@kpollich kpollich transferred this issue from elastic/kibana Mar 21, 2023
@jen-huang jen-huang added the good first issue Good for newcomers label Feb 1, 2024
@kaanyalti kaanyalti self-assigned this Mar 6, 2024
@kaanyalti kaanyalti assigned kaanyalti and unassigned kaanyalti Mar 21, 2024
@kaanyalti kaanyalti linked a pull request Apr 2, 2024 that will close this issue
8 tasks
@kaanyalti
Copy link
Contributor

Created this PR that shows that the error message mentioned in this issue is most probably not due to an expired CA.

https://github.com/elastic/fleet-server/pull/3423/files

@kpollich
Copy link
Member Author

kpollich commented Apr 3, 2024

Thanks Kaan, that PR demonstrates the specific error cases well. Appreciate you creating it and investigating here 🙏

The error messages in question come from Go's HTTP internals, and as such we don't really have a way to replace or improve them. I'm going to close this as not planned as a result.

@kpollich kpollich closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Team:Fleet Label for the Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants