Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o11y] Publish go-elasticsearch transport metrics through OTel measures #156

Open
inge4pres opened this issue Apr 17, 2024 · 0 comments
Open
Labels
enhancement New feature or request o11y

Comments

@inge4pres
Copy link

Describe the current state

The docappender Elasticsearch client used to perform HTTP requests has built-in support for some metrics (see https://github.com/elastic/elastic-transport-go/blob/6475398eb2a0e8fbef658ff3960f1f0c20741fb6/elastictransport/metrics.go#L43-L460)

We don't publish any of those at the moment through the docappender monitoring and have limited visibility on the performance and behavior of the client.

Describe the desired state

We would capture, transform to OTel format and publish the go-elasticsearch Transport metrics populated by the client lib.
With them we could be able to plot HTTP-request-level success rate (Failures / Requests ratio) as well as per-HTTP-status code rates (Responses by [key] / Requests).

Additional context

When designing how to expose the metrics, we should consider the possibility of adding arbitrary metadata to the data points exported. This is typically done with an attribute.Set in OTel, likely the existing MetricAttributes config field can be already serve this purpose.

@inge4pres inge4pres added enhancement New feature or request o11y labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request o11y
Projects
None yet
Development

No branches or pull requests

1 participant