feat: return an error when using small flush bytes with compression enabled #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nabled When compression is enabled the gzip writer will buffer data internally which will cause the unerlying buffer to grow from 0 to n once compression happens and compressed data are flushed. Because of this, small flush bytes values are ignored and will never be hit. The PR returns an error when using a small flush bytes value with compression enabled.
endorama
approved these changes
Jan 30, 2024
marclop
approved these changes
Jan 31, 2024
2 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95
When compression is enabled the gzip writer will buffer data internally
which will cause the unerlying buffer to grow from 0 to n once compression
happens and compressed data are flushed.
Because of this, small flush bytes values are ignored and will never be hit.
The PR returns an error when using a small flush bytes value with compression
enabled.
Users of this library are encouraged to have their own minimum value, log a warning and pass a bigger value if the value is too small.