Skip to content

Commit

Permalink
[8.x] [Discover] Fix console warning for invalid DOM property (#204417)…
Browse files Browse the repository at this point in the history
… (#204605)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Discover] Fix console warning for invalid DOM property
(#204417)](#204417)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Arturo Castillo
Delgado","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T15:49:36Z","message":"[Discover]
Fix console warning for invalid DOM property (#204417)\n\nFixes one of
the errors described in #202287 — namely a console warning\r\ndue to
invalid DOM
property.","sha":"59826ccdb55775261d2255d1483c40b3fbf60a21","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Feature:UnifiedDocViewer"],"title":"[Discover]
Fix console warning for invalid DOM
property","number":204417,"url":"https://github.com/elastic/kibana/pull/204417","mergeCommit":{"message":"[Discover]
Fix console warning for invalid DOM property (#204417)\n\nFixes one of
the errors described in #202287 — namely a console warning\r\ndue to
invalid DOM
property.","sha":"59826ccdb55775261d2255d1483c40b3fbf60a21"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204417","number":204417,"mergeCommit":{"message":"[Discover]
Fix console warning for invalid DOM property (#204417)\n\nFixes one of
the errors described in #202287 — namely a console warning\r\ndue to
invalid DOM
property.","sha":"59826ccdb55775261d2255d1483c40b3fbf60a21"}}]}]
BACKPORT-->

Co-authored-by: Arturo Castillo Delgado <[email protected]>
  • Loading branch information
kibanamachine and acstll authored Dec 17, 2024
1 parent 442d5f2 commit 34be3d4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const useFlyoutA11y = ({ isXlScreen }: { isXlScreen: boolean }) => {
a11yProps: {
ref: setFlyoutEl,
role: isXlScreen ? 'dialog' : undefined,
tabindex: isXlScreen ? 0 : undefined,
tabIndex: isXlScreen ? 0 : undefined,
'aria-describedby': isXlScreen ? descriptionId : undefined,
'data-no-focus-lock': isXlScreen || undefined,
},
Expand Down

0 comments on commit 34be3d4

Please sign in to comment.