[Rollups] Update rollup badges in Data view form (#187235)

Closes #186663 ## Summary Follow-up to #186321. This PR updates the Rollup badges in the Data view create form so that they show that Rollup is deprecated. <details> <summary>Before:</summary> <img width="1327" alt="Screenshot 2024-07-01 at 11 48 21" src="https://github.com/elastic/kibana/assets/59341489/9f4e1cd1-a34c-42dd-926a-ed6758f06ed7"> </details> <details> <summary>Now:</summary> <img width="1323" alt="Screenshot 2024-07-01 at 17 50 48" src="https://github.com/elastic/kibana/assets/59341489/084873f2-3707-46c4-b4ba-19b4e68c2d87"> <img width="1323" alt="Screenshot 2024-07-01 at 17 50 54" src="https://github.com/elastic/kibana/assets/59341489/d021ef34-3a84-4406-b23e-027aa2e8e868"> <img width="1323" alt="Screenshot 2024-07-01 at 17 50 59" src="https://github.com/elastic/kibana/assets/59341489/ef1246c5-00ed-4eaa-af21-e0515bce956a"> </details> **How to test:** 1. Start Es and Kibana 2. Add the sample data "Sample web logs" 3. Elasticsearch only allows creating a rollup job if there is an existing rollup usage in the cluster. To simulate rollup usage, create a mock rollup index through Console: ``` PUT /mock_rollup_index { "mappings": { "_meta": { "_rollup": { "id": "logs_job" } } } } ``` 4. Create a sample rollup job through Console: ``` PUT _rollup/job/logs_job { "id": "logs_job", "index_pattern": "kibana_sample_data_logs", "rollup_index": "rollup_logstash", "cron": "* * * * * ?", "page_size": 1000, "groups": { "date_histogram": { "interval": "60m", "delay": "7d", "time_zone": "UTC", "field": "@timestamp" }, "terms": { "fields": [ "geo.src", "machine.os.keyword" ] }, "histogram": { "interval": "1003", "fields": [ "bytes", "memory" ] } } } ``` 5. Delete the mock rollup index since it causes issues for the rollup API that we use to fetch rollup indices: `DELETE /mock_rollup_index` 6. Navigate to Stack Management -> Data Views and start creating a new data view. 7. Verify that the rollup badges are updated.  --------- Co-authored-by: kibanamachine <[email protected]>
elastic · Jul 2, 2024 · 628994e · 628994e
1 parent 6120167
commit 628994e
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 5 deletions.
diff --git a/src/plugins/data_view_editor/public/components/form_fields/type_field.tsx b/src/plugins/data_view_editor/public/components/form_fields/type_field.tsx
@@ -21,6 +21,7 @@ import {
 } from '@elastic/eui';
 
 import { INDEX_PATTERN_TYPE } from '@kbn/data-views-plugin/public';
+import { RollupDeprecationTooltip } from '@kbn/rollup';
 import { UseField } from '../../shared_imports';
 
 import { IndexPatternConfig } from '../../types';
@@ -57,6 +58,15 @@ const rollupSelectItem = (
       <EuiBadge color={euiLightVars.euiColorAccent}>
         <FormattedMessage id="indexPatternEditor.typeSelect.betaLabel" defaultMessage="Beta" />
       </EuiBadge>
+      &nbsp;
+      <RollupDeprecationTooltip>
+        <EuiBadge color="warning">
+          <FormattedMessage
+            id="indexPatternEditor.typeSelect.deprecatedBadge"
+            defaultMessage="Deprecated"
+          />
+        </EuiBadge>
+      </RollupDeprecationTooltip>
     </EuiDescriptionListTitle>
     <EuiDescriptionListDescription>
       <FormattedMessage
@@ -90,7 +100,7 @@ export const TypeField = ({ onChange }: TypeFieldProps) => {
                   {
                     value: INDEX_PATTERN_TYPE.ROLLUP,
                     inputDisplay: i18n.translate('indexPatternEditor.typeSelect.rollup', {
-                      defaultMessage: 'Rollup',
+                      defaultMessage: 'Rollup (deprecated)',
                     }),
                     dropdownDisplay: rollupSelectItem,
                   },

diff --git a/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx b/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx
@@ -27,7 +27,8 @@ import {
 import { Pager } from '@elastic/eui';
 import { Storage } from '@kbn/kibana-utils-plugin/public';
 import { FormattedMessage } from '@kbn/i18n-react';
-import { MatchedItem, Tag } from '@kbn/data-views-plugin/public';
+import { INDEX_PATTERN_TYPE, MatchedItem, Tag } from '@kbn/data-views-plugin/public';
+import { RollupDeprecationTooltip } from '@kbn/rollup';
 
 export interface IndicesListProps {
   indices: MatchedItem[];
@@ -205,11 +206,19 @@ export class IndicesList extends React.Component<IndicesListProps, IndicesListSt
           <EuiTableRowCell>{this.highlightIndexName(index.name, query)}</EuiTableRowCell>
           <EuiTableRowCell>
             {index.tags.map((tag: Tag) => {
-              return (
+              const badge = (
                 <EuiBadge key={`index_${key}_tag_${tag.key}`} color={tag.color}>
                   {tag.name}
                 </EuiBadge>
               );
+
+              return tag.key === INDEX_PATTERN_TYPE.ROLLUP ? (
+                <>
+                  &nbsp;<RollupDeprecationTooltip>{badge}</RollupDeprecationTooltip>
+                </>
+              ) : (
+                badge
+              );
             })}
           </EuiTableRowCell>
         </EuiTableRow>

diff --git a/src/plugins/data_view_editor/tsconfig.json b/src/plugins/data_view_editor/tsconfig.json
@@ -20,6 +20,7 @@
     "@kbn/kibana-utils-plugin",
     "@kbn/react-kibana-mount",
     "@kbn/code-editor",
+    "@kbn/rollup",
   ],
   "exclude": [
     "target/**/*",

diff --git a/src/plugins/data_views/public/services/get_indices.ts b/src/plugins/data_views/public/services/get_indices.ts
@@ -26,7 +26,7 @@ const frozenLabel = i18n.translate('dataViews.frozenLabel', {
 });
 
 const rollupLabel = i18n.translate('dataViews.rollupLabel', {
-  defaultMessage: 'Rollup',
+  defaultMessage: 'Rollup (deprecated)',
 });
 
 const getIndexTags = (isRollupIndex: (indexName: string) => boolean) => (indexName: string) =>
@@ -35,7 +35,7 @@ const getIndexTags = (isRollupIndex: (indexName: string) => boolean) => (indexNa
         {
           key: INDEX_PATTERN_TYPE.ROLLUP,
           name: rollupLabel,
-          color: 'primary',
+          color: 'warning',
         },
       ]
     : [];