[VisEditors] Add code ownership to the functional tests (#111680)

* [VisEditors] Add code owenership to the functional tests * Remove the unnecessary imports * Revert Co-authored-by: Kibana Machine <[email protected]>
elastic · Sep 13, 2021 · d60fab1 · d60fab1
1 parent 15a31a1
commit d60fab1
Show file tree

Hide file tree

Showing 10 changed files with 37 additions and 2 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -40,6 +40,8 @@
 /src/plugins/chart_expressions/expression_tagcloud/ @elastic/kibana-vis-editors
 /src/plugins/url_forwarding/ @elastic/kibana-vis-editors
 /packages/kbn-tinymath/ @elastic/kibana-vis-editors
+/x-pack/test/functional/apps/lens @elastic/kibana-vis-editors
+/test/functional/apps/visualize/ @elastic/kibana-vis-editors
 
 # Application Services
 /examples/bfetch_explorer/ @elastic/kibana-app-services
@@ -146,6 +148,7 @@
 /src/plugins/vis_type_markdown/ @elastic/kibana-presentation
 /src/plugins/presentation_util/ @elastic/kibana-presentation
 /test/functional/apps/dashboard/  @elastic/kibana-presentation
+/test/functional/apps/dashboard_elements/  @elastic/kibana-presentation
 /x-pack/plugins/canvas/  @elastic/kibana-presentation
 /x-pack/plugins/dashboard_enhanced/ @elastic/kibana-presentation
 /x-pack/test/functional/apps/canvas/  @elastic/kibana-presentation

diff --git a/...unctional/apps/visualize/_markdown_vis.ts → .../apps/dashboard_elements/_markdown_vis.ts b/...unctional/apps/visualize/_markdown_vis.ts → .../apps/dashboard_elements/_markdown_vis.ts
diff --git a/test/functional/apps/dashboard_elements/index.ts b/test/functional/apps/dashboard_elements/index.ts
@@ -0,0 +1,33 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { FtrProviderContext } from '../../ftr_provider_context';
+
+export default function ({ getService, loadTestFile }: FtrProviderContext) {
+  const browser = getService('browser');
+  const log = getService('log');
+  const esArchiver = getService('esArchiver');
+
+  describe('dashboard elements', () => {
+    before(async () => {
+      log.debug('Starting before method');
+      await browser.setWindowSize(1280, 800);
+      await esArchiver.load('test/functional/fixtures/es_archiver/empty_kibana');
+
+      await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
+      await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/long_window_logstash');
+    });
+
+    describe('dashboard elements ciGroup10', function () {
+      this.tags('ciGroup10');
+
+      loadTestFile(require.resolve('./input_control_vis'));
+      loadTestFile(require.resolve('./_markdown_vis'));
+    });
+  });
+}
diff --git a/...ize/input_control_vis/chained_controls.ts → ...nts/input_control_vis/chained_controls.ts b/...ize/input_control_vis/chained_controls.ts → ...nts/input_control_vis/chained_controls.ts
diff --git a/...lize/input_control_vis/dynamic_options.ts → ...ents/input_control_vis/dynamic_options.ts b/...lize/input_control_vis/dynamic_options.ts → ...ents/input_control_vis/dynamic_options.ts
diff --git a/...apps/visualize/input_control_vis/index.ts → ...board_elements/input_control_vis/index.ts b/...apps/visualize/input_control_vis/index.ts → ...board_elements/input_control_vis/index.ts
diff --git a/...nput_control_vis/input_control_options.ts → ...nput_control_vis/input_control_options.ts b/...nput_control_vis/input_control_options.ts → ...nput_control_vis/input_control_options.ts
diff --git a/.../input_control_vis/input_control_range.ts → .../input_control_vis/input_control_range.ts b/.../input_control_vis/input_control_range.ts → .../input_control_vis/input_control_range.ts
diff --git a/test/functional/apps/visualize/index.ts b/test/functional/apps/visualize/index.ts
@@ -70,7 +70,6 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
       loadTestFile(require.resolve('./_experimental_vis'));
       loadTestFile(require.resolve('./_gauge_chart'));
       loadTestFile(require.resolve('./_heatmap_chart'));
-      loadTestFile(require.resolve('./input_control_vis'));
       loadTestFile(require.resolve('./_histogram_request_start'));
       loadTestFile(require.resolve('./_metric_chart'));
     });
@@ -79,7 +78,6 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
       this.tags('ciGroup4');
 
       loadTestFile(require.resolve('./_pie_chart'));
-      loadTestFile(require.resolve('./_markdown_vis'));
       loadTestFile(require.resolve('./_shared_item'));
       loadTestFile(require.resolve('./_lab_mode'));
       loadTestFile(require.resolve('./_linked_saved_searches'));

diff --git a/test/functional/config.js b/test/functional/config.js
@@ -19,6 +19,7 @@ export default async function ({ readConfigFile }) {
       require.resolve('./apps/console'),
       require.resolve('./apps/context'),
       require.resolve('./apps/dashboard'),
+      require.resolve('./apps/dashboard_elements'),
       require.resolve('./apps/discover'),
       require.resolve('./apps/getting_started'),
       require.resolve('./apps/home'),