Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining test files from *.js to *.ts #116415

Closed
mshustov opened this issue Oct 27, 2021 · 2 comments
Closed

Migrate remaining test files from *.js to *.ts #116415

mshustov opened this issue Oct 27, 2021 · 2 comments
Labels
discuss DX Issues related to Developer Experience impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team technical debt Improvement of the software architecture and operational architecture

Comments

@mshustov
Copy link
Contributor

mshustov commented Oct 27, 2021

I intentionally omitted the broad migration across the whole codebases since most of the plugins already rely on *.ts in the plugin codebase but keep functional tests in *.js.

One of the pain points working on #113950 was lots of problems in ./test and ./x-pack/test folders caused by the lack of typings.
There are 412 *.js files in ./test and ./x-pack/test folders and lots of places that misuse any (like it used to be es: any here)

I’m wondering whether we should start working towards *.js files migration to *.ts. We've already been tracking the number of any in the public API. Similarly, we could start tracking the number of *.js files per team, which in turn, requires defining owners for all the functional tests.

It isn't a critical problem. But it affects DX when someone (usually the Kibana Platform team) has to fix issues in an unfamiliar domain. For example, logic in ./test and x-pack/test do not have tests, and the only way to investigate an FTR failure is to debug it in runtime that is slow by design.

cc @elastic/kibana-operations

@mshustov mshustov added discuss DX Issues related to Developer Experience labels Oct 27, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 27, 2021
@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team labels Oct 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 27, 2021
@lukeelmers lukeelmers added the technical debt Improvement of the software architecture and operational architecture label Nov 1, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Feb 16, 2022
@tylersmalley tylersmalley removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Mar 16, 2022
@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Mar 17, 2022
@pgayvallet
Copy link
Contributor

AFAIK, all the .js files under Core's responsibilities have been migrated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss DX Issues related to Developer Experience impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

5 participants