Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]Filter out , Filter in present for actual rendrer for alert attached to cases. #156519

Open
sukhwindersingh-qasource opened this issue May 3, 2023 · 12 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. response-ops-mx-backlog ResponseOps MX backlog Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.10.0

Comments

@sukhwindersingh-qasource

Describe the bug:

  • Filter out , Filter in present for actual rendrer for alert attached to cases.

Build Details:

VERSION: 8.8.0 BC1
BUILD: 62765
COMMIT: d0327fc75720e56ee76b640f07ffd1b154a348a8

Preconditions

  • Deploy a build of 8.7.0
  • Alerts should be present.
  • Attach alert to a case.

Steps to Reproduce

  • Navigate to cases tab.
  • Click on alerts.
  • Open alerts details page.
  • Observe that Filter out , Filter in present for actual rendrer for alert attached to cases.

Actual Result

  • Filter out , Filter in present for actual rendrer for alert attached to cases.

Expected Result

  • Filter out , Filter should not be present for actual rendrer for alert attached to cases.
  • As it should be consistent.

Screen-recording

Cases.-.Kibana.Mozilla.Firefox.2023-05-03.17-27-01.mp4

Screen-shot
image

@sukhwindersingh-qasource sukhwindersingh-qasource added bug Fixes for quality problems that affect the customer experience triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels May 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost assigned MadameSheema and unassigned ghost May 3, 2023
@michaelolo24 michaelolo24 added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label May 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@MadameSheema MadameSheema assigned XavierM and unassigned MadameSheema May 3, 2023
@semd
Copy link
Contributor

semd commented May 4, 2023

We could consider migrating this to the new cell-actions package. We could solve this problem by passing disabledActionTypes={[FILTER_CELL_ACTION_TYPE]} to the CellActions component when the flyout is rendered on the Cases alerts page.

@semd
Copy link
Contributor

semd commented Jul 13, 2023

Should've been fixed here #134442

@michaelolo24
Copy link
Contributor

Should've been fixed here #134442

sukhwindersingh-qasource can you please confirm this fix? And if you have time could you also take a look at the issue @semd commented here? Thank you!

@sukhwindersingh-qasource
Copy link
Author

Hi @michaelolo24

We have validated this issue on 8.9.0 BC5 build and observed that issue looks like , It is still occurring

Please find the below Testing Details:

Build info

VERSION: 8.9.0 BC5
BUILD: 64715
COMMIT: beb56356c5c037441f89264361302513ff5bd9f8

Screen-Shot

image

Hence, We will regress this ticket on 8.10.0 BC1
Thanks!!

@MadameSheema
Copy link
Member

@sukhwindersingh-qasource the fix is not available on 8.9. Can you please take a look at latest main branch or latest 8.10.0-SNAPSHOT? Thanks!

@sukhwindersingh-qasource
Copy link
Author

Hi @MadameSheema

We have validated this issue on 8.10.0 Latest Snapshot build and observed that issue looks like , It is still occurring

Please find the below Testing Details:

Build info

VERSION: 8.10.0 Snapshot
BUILD: 65311
COMMIT: 0d8a2da9792caef4171c31c71b3836ec5e44bdb4

Screen-Recording

Cases.-.Kibana.Mozilla.Firefox.2023-07-26.18-07-39.mp4

We will regress this ticket on main branch.
Thanks!!

@ghost
Copy link

ghost commented Jul 27, 2023

Hi @michaelolo24

we have checked into the mains code and checked this issue and as per our understanding on reading the semd comment #134442 (comment) the filter out should be disabled or hide out but they are still visible and clickable.

Please find details below:

video1739650887_AdobeExpress.mp4

Do let us know if we are missing anything we can recheck it .

thanks!!

c.c @MadameSheema

@MadameSheema
Copy link
Member

@michaelolo24 @semd any idea about if this fix is going to make to to 8.9.1? Thanks!

@semd
Copy link
Contributor

semd commented Aug 1, 2023

Okay, I misunderstood where it was happening.
It would need a bit of investigation to know if we can exclude these actions in a similar fashion to what was done in the table. If it is possible to discriminate the details flyout we use in the Cases page from the rest (probably with a scopeId or similar), it should be easy to pass the disabledActionTypes prop to the component the same way we did here for the table cell actions

@MadameSheema
Copy link
Member

MadameSheema commented Aug 23, 2023

This is still an issue on 8.10.0BC2. The option is also available on highlighted fields.

Screenshot 2023-08-23 at 16 58 21

Removing the fixed label since there is still work pending to be done.

cc @XavierM @michaelolo24 @semd

@Zacqary Zacqary moved this from Up for grabs to In Progress in AppEx: ResponseOps - Rules & Alerts Management Feb 6, 2024
@cnasikas cnasikas added response-ops-mx-backlog ResponseOps MX backlog and removed Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. response-ops-mx-backlog ResponseOps MX backlog Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.10.0
Projects
No open projects
Development

No branches or pull requests

7 participants