Warning sign on same terms for different color mapping doesn't display any message to the user #167880
Comments
bhavyarm
added
bug
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
stratoula
added
enhancement
|
@MichaelMarcialis @markov00 what do you think about this feedback here? |
|
@MichaelMarcialis I can't add tooltip to the combobox element unfortunately, so the only think I can do for now is to add something like that when the warning sign is visible. What do you think? In case we can remove completely the duplicate icon, it still work fine and doesn't have any big impact. Only the fact that the user needs to understand by them selfs that the color will be applied to the first assignment that matches with the rule |
|
@bhavyarm: Funny that you mention this, as I also mention this behavior in my issue here: #167703 @stratoula, @markov00: In general, I'd prefer it if we could do everything in our power to prevent the user from having to sift through errors and warnings when possible. This is already a robust interface. Any opportunity we can take to avoid adding more "stuff" to it will be a good thing. As such, for the short-term, I'd recommend the following:
Longer-term, I don't think we should be allowing users to get into this situation in the first place. In the aforementioned issue, I suggested that if a user attempts to apply a term already in use to another color assignment, we simply treat it as a swap and remove the previous term assignment. Marco had some concerns with that suggestion, but I tried to explain why I feel it is still a viable approach in a follow-up comment here: #167703 (comment) Thoughts? |
## Summary Fixes the following issues with the Color mapping MVP (see [here](#167506)): - refactored the color contrast check and the RGB text input to avoid popover flickering - replaced categorical/sequential icons for color scales - add dot to complete the tooltip sentence. - fix #167880 by adding a tooltip to the warning sign
## Summary Fixes the following issues with the Color mapping MVP (see [here](elastic#167506)): - refactored the color contrast check and the RGB text input to avoid popover flickering - replaced categorical/sequential icons for color scales - add dot to complete the tooltip sentence. - fix elastic#167880 by adding a tooltip to the warning sign (cherry picked from commit 6f62f7b)
# Backport This will backport the following commits from `main` to `8.11`: - [[lens] color mapping general ux fixes (#167997)](#167997) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-05T21:11:21Z","message":"[lens] color mapping general ux fixes (#167997)\n\n## Summary\r\n\r\nFixes the following issues with the Color mapping MVP (see\r\n[here](https://github.com/elastic/kibana/issues/167506)):\r\n- refactored the color contrast check and the RGB text input to avoid\r\npopover flickering\r\n- replaced categorical/sequential icons for color scales\r\n- add dot to complete the tooltip sentence.\r\n- fix #167880 by adding a\r\ntooltip to the warning sign","sha":"6f62f7b5a65be6d99e9b3a0092304966b7a7bbf4","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.11.0","v8.12.0"],"number":167997,"url":"https://github.com/elastic/kibana/pull/167997","mergeCommit":{"message":"[lens] color mapping general ux fixes (#167997)\n\n## Summary\r\n\r\nFixes the following issues with the Color mapping MVP (see\r\n[here](https://github.com/elastic/kibana/issues/167506)):\r\n- refactored the color contrast check and the RGB text input to avoid\r\npopover flickering\r\n- replaced categorical/sequential icons for color scales\r\n- add dot to complete the tooltip sentence.\r\n- fix #167880 by adding a\r\ntooltip to the warning sign","sha":"6f62f7b5a65be6d99e9b3a0092304966b7a7bbf4"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167997","number":167997,"mergeCommit":{"message":"[lens] color mapping general ux fixes (#167997)\n\n## Summary\r\n\r\nFixes the following issues with the Color mapping MVP (see\r\n[here](https://github.com/elastic/kibana/issues/167506)):\r\n- refactored the color contrast check and the RGB text input to avoid\r\npopover flickering\r\n- replaced categorical/sequential icons for color scales\r\n- add dot to complete the tooltip sentence.\r\n- fix #167880 by adding a\r\ntooltip to the warning sign","sha":"6f62f7b5a65be6d99e9b3a0092304966b7a7bbf4"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
## Summary Fixes the following issues with the Color mapping MVP (see [here](elastic#167506)): - refactored the color contrast check and the RGB text input to avoid popover flickering - replaced categorical/sequential icons for color scales - add dot to complete the tooltip sentence. - fix elastic#167880 by adding a tooltip to the warning sign
Kibana version: 8.11.0 snapshot from Oct 1st
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from snapshots
Describe the bug: Right now users can assign the same terms to different colors in color mapping. There is a warning sign when users do this. But no helpful hint gets displayed. Could we please let the user know whats happening?
The text was updated successfully, but these errors were encountered: